This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
Update javassist to 3.22.0-GA and GWT mockito to 1.1.7 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
force-pushed
the
update-javassist
branch
from
38eca21 to
28dd77b
Compare
benoitf
changed the title
skabashnyuk
approved these changes
Oct 27, 2017
|
yes sure, BTW I've provided PR for GWT Mockito project as well so I'm waiting some feedback as well. |
benoitf
changed the title
|
CQs accepted |
vparfonov
approved these changes
Nov 3, 2017
|
I will merge this PR on monday |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CQs
What does this PR do?
Update javassist to a version compliant with Java9
Also update GWT mockito to 1.1.7 compliant with javassit 3.22
What issues does this PR fix or reference?
eclipse-che/che#5326
Previous behavior
Some failures when using it with Java9
New behavior
Fix failures with Java9
Tests written?
No
Docs updated?
No