This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
Add new dependency: com.squareup.okhttp3:okhttp #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
reviewed
Mar 9, 2017
pom.xml
Outdated
| @@ -45,6 +45,7 @@ | |||
| <com.googlecode.gson.version>2.3.1</com.googlecode.gson.version> | |||
| <com.h2database.version>1.4.192</com.h2database.version> | |||
| <com.jcraft.jsch.version>0.1.53</com.jcraft.jsch.version> | |||
| <com.squareup.okhttp3>3.4.2</com.squareup.okhttp3> | |||
There was a problem hiding this comment.
Could we use com.square.okhttp3.version to match the other variables?
skabashnyuk
approved these changes
Mar 9, 2017
Signed-off-by: Snjezana Peco <[email protected]>
|
@amisevsk can you make sure that |
|
@skabashnyuk We are currently updating dependencies in the openshift-connector branch to avoid having to go through the CQ process too frequently. As Che issue #2847 progresses, we'll probably have to update these same dependencies again (e.g. if we need to move to a newer version of kubernetes-client). Once we open a PR to merge the openshift-connector branch into master, we'll go through and ensure CQs are opened on all updated transitive dependencies. |
|
ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new dependency: com.squareup.okhttp3:okhttp - eclipse-che/che#4363