Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the SSH validation pattern for the git URL input #890

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Allow to input SSH url in the Bitbucket-server format: ssh://[email protected]:7999/~user/repo.git

What issues does this PR fix or reference?

eclipse-che/che#22354

Is it tested? How?

Paste ssh://[email protected]:7999/~user/repo.git to the Git Repo URL input in the Create Workspace tab
See validation is passed.

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Aug 7, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-890

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #890 (d9564d6) into main (549cd4e) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage   81.67%   81.67%           
=======================================
  Files         347      347           
  Lines       35901    35901           
  Branches     2239     2239           
=======================================
  Hits        29321    29321           
  Misses       6558     6558           
  Partials       22       22           
Flag Coverage Δ
unittests 81.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...end/src/services/factory-location-adapter/index.ts 100.00% <100.00%> (ø)

@openshift-ci
Copy link

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk ibuziuk merged commit c35de23 into main Aug 7, 2023
@ibuziuk ibuziuk deleted the che-22354 branch August 7, 2023 15:31
@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/293: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/3875: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/293: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3928 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: sync-to-downstream_3.x/3930: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3784 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.9 :: operator-bundle_3.x/1697: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3930 triggered

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1633: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: dsc_3.x/1123: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/3875: SUCCESS

Detected new images: rebuild operator-bundle
* code
* configbump
* dashboard
* devfileregistry
* devspaces-operator
* machineexec
* pluginregistry
* server
* traefik
* udi; /DS_CI/operator-bundle_3.x/1697 triggered

@devstudio-release
Copy link

Build 3.9 :: dsc_3.x/1123: SUCCESS

3.9.0 CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants