Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the sequence of injections #812

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented May 11, 2023

What does this PR do?

Change the sequence of injections

What issues does this PR fix or reference?

eclipse-che/che#22140

Is it tested? How?

  1. Deploy
  2. Create and open a new workspace
  3. Execute podman pull image-registry.openshift-image-registry.svc:5000/openshift/cli:latest --tls-verify=false

Знімок екрана 2023-05-11 о 13 12 09

@olexii4 olexii4 requested a review from ibuziuk May 11, 2023 10:12
@olexii4 olexii4 requested a review from akurinnoy as a code owner May 11, 2023 10:12
@che-bot
Copy link
Contributor

che-bot commented May 11, 2023

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 force-pushed the quick_fix_podman_login branch from cf049b4 to b49da5b Compare May 11, 2023 10:17
@che-bot
Copy link
Contributor

che-bot commented May 11, 2023

Click here to review and test in web IDE: Contribute

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if this would change much
requests are passing for me even with the current sequence - eclipse-che/che#22140 (comment)

@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-812

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-812

@olexii4 olexii4 merged commit ee2b623 into main May 11, 2023
@olexii4 olexii4 deleted the quick_fix_podman_login branch May 11, 2023 10:40
@devstudio-release
Copy link

Build 3.7 :: dashboard_3.x/267: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.7 :: update-digests_3.x/3138: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.7 :: dashboard_3.x/267: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3420 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.7 :: copyIIBsToQuay/1403: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.7 :: sync-to-downstream_3.x/3421: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3219 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.7 :: operator-bundle_3.x/1296: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3421 triggered

@devstudio-release
Copy link

Build 3.7 :: dsc_3.x/952: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.7 :: update-digests_3.x/3138: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/1296 triggered

@devstudio-release
Copy link

Build 3.7 :: dsc_3.x/952: SUCCESS

3.7.0 CI

@devstudio-release
Copy link

Build 3.7 :: copyIIBsToQuay/1403: SUCCESS

3.7
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.7-173
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.20-3
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.7-v4.13-494854-484865-s390x
  + quay.io/devspaces/iib:3.7-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.7-v4.12-494853-484860-s390x
  + quay.io/devspaces/iib:3.7-v4.11-494852-484854-s390x
  + quay.io/devspaces/iib:3.7-v4.10-495219-484851-s390x
  + quay.io/devspaces/iib:3.7-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.7-v4.13-494854-484865-ppc64le
  + quay.io/devspaces/iib:3.7-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.7-v4.12-494853-484860-ppc64le
  + quay.io/devspaces/iib:3.7-v4.11-495222-484854-ppc64le
  + quay.io/devspaces/iib:3.7-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.7-v4.10-495219-484851-ppc64le
  + quay.io/devspaces/iib:3.7-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.7-v4.13-494854-484865-x86_64
  + quay.io/devspaces/iib:3.7-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.7-v4.12-494853-484860-x86_64
  + quay.io/devspaces/iib:3.7-v4.11-495222-484854-x86_64
  + quay.io/devspaces/iib:3.7-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.7-v4.10-495219-484851-x86_64
  + quay.io/devspaces/iib:3.7-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants