-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move some defaults out of CheCluster to env variables #759
Conversation
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759 |
Signed-off-by: Anatolii Bazko <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759 |
Signed-off-by: Anatolii Bazko <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759 |
packages/dashboard-backend/src/devworkspaceClient/services/serverConfigApi.ts
Outdated
Show resolved
Hide resolved
…verConfigApi.ts Co-authored-by: Oleksii Orel <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759 |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759 |
Signed-off-by: Anatolii Bazko <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759 |
Codecov Report
@@ Coverage Diff @@
## main #759 +/- ##
==========================================
- Coverage 77.67% 77.57% -0.10%
==========================================
Files 317 318 +1
Lines 31276 31450 +174
Branches 1867 1887 +20
==========================================
+ Hits 24294 24398 +104
- Misses 6931 7000 +69
- Partials 51 52 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.6 :: dashboard_3.x/222: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2767: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1982: Console, Changes, Git Data |
Build 3.6 :: get-sources-rhpkg-container-build_3.x/2602: dashboard : 3.x :: Build 51580539 : quay.io/devspaces/dashboard-rhel8:3.6-25 |
Build 3.6 :: dashboard_3.x/222: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2767 triggered |
Build 3.6 :: update-digests_3.x/2578: Console, Changes, Git Data |
Build 3.6 :: update-digests_3.x/2578: No new images detected: nothing to do! |
…che#759) * feat: Move some defaults out of CheCluster to env variables Signed-off-by: Anatolii Bazko <[email protected]> Co-authored-by: Oleksii Orel <[email protected]>
What does this PR do?
feat: Move some defaults out of CheCluster to env variables
What issues does this PR fix or reference?
eclipse-che/che#22064
Is it tested? How?
N/A
Release Notes
Docs PR