Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move some defaults out of CheCluster to env variables #759

Merged
merged 7 commits into from
Mar 24, 2023
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Mar 20, 2023

What does this PR do?

feat: Move some defaults out of CheCluster to env variables

What issues does this PR fix or reference?

eclipse-che/che#22064

Is it tested? How?

N/A

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Mar 20, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Anatolii Bazko <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Mar 21, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759

Signed-off-by: Anatolii Bazko <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Mar 21, 2023
@che-bot
Copy link
Contributor

che-bot commented Mar 21, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759

Signed-off-by: Anatolii Bazko <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Mar 21, 2023

Click here to review and test in web IDE: Contribute

@tolusha tolusha requested a review from akurinnoy March 21, 2023 15:45
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759

@che-bot
Copy link
Contributor

che-bot commented Mar 22, 2023

Click here to review and test in web IDE: Contribute

@eclipse-che eclipse-che deleted a comment from olexii4 Mar 22, 2023
@eclipse-che eclipse-che deleted a comment from olexii4 Mar 22, 2023
Signed-off-by: Anatolii Bazko <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Mar 22, 2023

Click here to review and test in web IDE: Contribute

@openshift-ci openshift-ci bot added the lgtm label Mar 22, 2023
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759

Signed-off-by: Anatolii Bazko <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Mar 23, 2023
@che-bot
Copy link
Contributor

che-bot commented Mar 23, 2023

Click here to review and test in web IDE: Contribute

@tolusha tolusha requested review from olexii4 and akurinnoy March 23, 2023 14:16
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-759

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #759 (0112a60) into main (29164d1) will decrease coverage by 0.10%.
The diff coverage is 59.79%.

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
- Coverage   77.67%   77.57%   -0.10%     
==========================================
  Files         317      318       +1     
  Lines       31276    31450     +174     
  Branches     1867     1887      +20     
==========================================
+ Hits        24294    24398     +104     
- Misses       6931     7000      +69     
- Partials       51       52       +1     
Flag Coverage Δ
unittests 77.57% <59.79%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...board-frontend/src/store/ServerConfig/selectors.ts 93.18% <0.00%> (-2.28%) ⬇️
.../src/routes/api/helpers/getCertificateAuthority.ts 42.66% <17.94%> (-24.00%) ⬇️
...src/devworkspaceClient/services/serverConfigApi.ts 68.82% <36.84%> (-6.00%) ⬇️
...ontend/src/store/Workspaces/devWorkspaces/index.ts 80.70% <65.90%> (-0.68%) ⬇️
...s/dashboard-frontend/src/store/Workspaces/index.ts 58.04% <66.66%> (+0.13%) ⬆️
...-frontend/src/services/workspace-client/helpers.ts 87.42% <81.81%> (-1.47%) ⬇️
...-frontend/src/store/DevfileRegistries/getEditor.ts 93.47% <93.47%> (ø)
.../CommonSteps/CheckRunningWorkspacesLimit/index.tsx 93.08% <100.00%> (+0.28%) ⬆️
...iners/Loader/Factory/Steps/Apply/Devfile/index.tsx 83.08% <100.00%> (+0.10%) ⬆️
.../dashboard-frontend/src/pages/GetStarted/index.tsx 71.20% <100.00%> (+0.11%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openshift-ci openshift-ci bot added the lgtm label Mar 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/222: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/222: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2767 triggered

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2578: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2578: UNSTABLE

No new images detected: nothing to do!

ScrewTSW pushed a commit to ScrewTSW/che-dashboard that referenced this pull request Jul 14, 2023
…che#759)

* feat: Move some defaults out of CheCluster to env variables

Signed-off-by: Anatolii Bazko <[email protected]>
Co-authored-by: Oleksii Orel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants