Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when unsupported Devfile features used #727

Merged
merged 7 commits into from
Mar 13, 2023

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Feb 15, 2023

What does this PR do?

This PR show warnings that may happen during workspace creation when the devfile uses unsupported features.

Screenshot 2023-03-03 at 18 44 54

What issues does this PR fix or reference?

resolves eclipse-che/che#21873

Is it tested? How?

Try creating a workspace using the following devfile:

schemaVersion: 2.1.0
metadata:
  generateName: unsupported-feature-
components:
  - name: web-terminal
    container:
      image: quay.io/wto/web-terminal-tooling:next
      memoryLimit: 512Mi
      mountSources: true
      command:
       - "tail"
       - "-f"
       - "/dev/null"
      dedicatedPod: true # This feature is unsupported

@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Feb 15, 2023

Click here to review and test in web IDE: Contribute

@akurinnoy akurinnoy force-pushed the unsupported-devfile-features-warning branch from 492f795 to 60b70e5 Compare February 15, 2023 08:29
@che-bot
Copy link
Contributor

che-bot commented Feb 15, 2023

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #727 (7f154dc) into main (21c06d0) will decrease coverage by 0.02%.
The diff coverage is 74.20%.

@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   77.66%   77.64%   -0.02%     
==========================================
  Files         317      317              
  Lines       31084    31230     +146     
  Branches     1841     1862      +21     
==========================================
+ Hits        24140    24249     +109     
- Misses       6894     6930      +36     
- Partials       50       51       +1     
Flag Coverage Δ
unittests 77.64% <74.20%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rd-backend/src/routes/api/devworkspaceResources.ts 61.11% <0.00%> (ø)
...-frontend/src/components/Loader/Progress/index.tsx 100.00% <ø> (+10.90%) ⬆️
...orkspace-client/devworkspace/devWorkspaceClient.ts 65.30% <31.76%> (-6.44%) ⬇️
...-frontend/src/components/WorkspaceEvents/index.tsx 99.31% <50.00%> (-0.69%) ⬇️
...rvices/dashboard-backend-client/devWorkspaceApi.ts 58.82% <66.66%> (+0.61%) ⬆️
...src/devworkspaceClient/services/devWorkspaceApi.ts 66.18% <80.00%> (+1.40%) ⬆️
...oard-frontend/src/components/Loader/Step/index.tsx 92.46% <81.48%> (-3.09%) ⬇️
...ontend/src/store/Workspaces/devWorkspaces/index.ts 81.38% <83.63%> (+0.08%) ⬆️
...ers/Loader/Factory/Steps/Apply/Resources/index.tsx 96.01% <90.90%> (-0.66%) ⬇️
...iners/Loader/Factory/Steps/Apply/Devfile/index.tsx 82.97% <92.30%> (+0.76%) ⬆️
... and 7 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-727

@che-bot
Copy link
Contributor

che-bot commented Mar 3, 2023

Click here to review and test in web IDE: Contribute

@akurinnoy akurinnoy force-pushed the unsupported-devfile-features-warning branch from db271a7 to 407658b Compare March 3, 2023 17:14
@che-bot
Copy link
Contributor

che-bot commented Mar 3, 2023

Click here to review and test in web IDE: Contribute

@akurinnoy akurinnoy marked this pull request as ready for review March 3, 2023 17:15
@akurinnoy akurinnoy requested a review from olexii4 as a code owner March 3, 2023 17:15
@akurinnoy akurinnoy force-pushed the unsupported-devfile-features-warning branch from 407658b to 3bca7e8 Compare March 6, 2023 09:26
@che-bot
Copy link
Contributor

che-bot commented Mar 6, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-727

@che-bot
Copy link
Contributor

che-bot commented Mar 6, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-727

@akurinnoy akurinnoy requested a review from ibuziuk March 6, 2023 13:21
@che-bot
Copy link
Contributor

che-bot commented Mar 13, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-727

@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, amisevsk, AObuchow, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit 506fa59 into main Mar 13, 2023
@akurinnoy akurinnoy deleted the unsupported-devfile-features-warning branch March 13, 2023 15:11
@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/218: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@che-bot che-bot added this to the 7.63 milestone Mar 13, 2023
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2482: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/218: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2721 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1150: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: sync-to-downstream_3.x/2722: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2563 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/1010: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2722 triggered

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/716: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2482: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/1010 triggered

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/716: SUCCESS

3.6.0 CI

ScrewTSW pushed a commit to ScrewTSW/che-dashboard that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Show warning when unsupported Devfile features used
8 participants