Enable the container build capabilities on workspace startup #655
Conversation
|
Click here to review and test in web IDE: |
| @@ -27,6 +27,6 @@ export async function getServerConfig(): Promise<api.IServerConfig> { | |||
| const response = await axios.get(url); | |||
| return response.data ? response.data : []; | |||
| } catch (e) { | |||
| throw `Failed to fetch default plugins. ${common.helpers.errors.getMessage(e)}`; | |||
| throw new Error(`Failed to fetch default plugins. ${common.helpers.errors.getMessage(e)}`); | |||
There was a problem hiding this comment.
It is a wrong message:
'Failed to fetch default plugins...'
| @@ -97,7 +98,7 @@ export function devWorkspaceToDevfile(devworkspace: devfileApi.DevWorkspace): de | |||
| template.events = devworkspace.spec.template.events; | |||
| } | |||
| if (devworkspace.spec.template.attributes) { | |||
| const devWorkspaceAttributes: { [key: string]: any } = {}; | |||
| const devWorkspaceAttributes: { [key: string]: unknown } = {}; | |||
There was a problem hiding this comment.
We already have the needed type:
{ [key: string]: unknown }
=>
DevWorkspaceSpecTemplateAttribute
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-655 |
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-655 |
|
@akurinnoy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Inject (or remove) the container build attribute. CR property
spec.devEnvironments.disableContainerBuildCapabilitiesdefines when to enable the container build capabilities; another CR propertyspec.devEnvironments.containerBuildConfiguration.openShiftSecurityContextConstraintcontains the container build attribute value the dashboard injects on a workspace startup.What issues does this PR fix or reference?
resolves eclipse-che/che#21756
Is it tested? How?