chore: cherry-pick #625 to 7.52.x

[AObuchow]

What does this PR do?

Add changes from #625 into the 7.52.x branch.

This back port led to some conflicts, so hopefully I resolved them properly. If not, feel free to either modify this PR or discard it and redo it yourself.

What issues does this PR fix or reference?

eclipse-che/che#21405

Is it tested? How?

I ran the automated tests with npm run test

[che-bot]

Click here to review and test in web IDE:

[openshift-ci]

Hi @AObuchow. Thanks for your PR.

I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nickboldt]

So that the commit log is more clear about blockers fixed for the product, can you update your commit message so it refers to the original commit message? Add external attributes to workspaces is much more descriptive than cherrypick #625, and will make it immediately obvious when checking the commit log that a fix was ported (and especially WHY).

[AObuchow]

So that the commit log is more clear about blockers fixed for the product, can you update your commit message so it refers to the original commit message? Add external attributes to workspaces is much more descriptive than cherrypick #625, and will make it immediately obvious when checking the commit log that a fix was ported (and especially WHY).

Sounds good to me - will update it shortly :)

[che-bot]

Click here to review and test in web IDE:

[nickboldt]

LGTM (in terms of commit message metadata) but not an SME so don't trust me here... especially with the comment above about that this cherrypick broke stuff and wasn't completely straightforward.

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[nickboldt]

dumb question.... do we need to run tests with node 14? it's EOL soon and 16 is the LTS version

https://endoflife.date/nodejs

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AObuchow, nickboldt, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[che-bot]

Click here to review and test in web IDE:

[nickboldt]

the PR checks will never pass because they require docker login to quay.io, which uses secrets that will never be accessible to @AObuchow 's fork, only this repo.

[nickboldt]

Closing in favour of #635