-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Implement editor agnostic kubeconfig injection #431
Conversation
9c5e4c1
to
141ba19
Compare
141ba19
to
18c1e0d
Compare
Signed-off-by: Josh Pinkney <[email protected]>
18c1e0d
to
13fc9cb
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-431 |
/test v8-dashboard-happy-path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 50.80% 50.29% -0.52%
==========================================
Files 216 219 +3
Lines 7434 7526 +92
Branches 1235 1249 +14
==========================================
+ Hits 3777 3785 +8
- Misses 3298 3382 +84
Partials 359 359
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, JPinkney, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Josh Pinkney [email protected]
What does this PR do?
This PR implements editor agnostic kubeconfig injection for devworkspaces by calling a new endpoint
/namespace/:namespace/devworkspaceId/:devworkspaceId/kubeconfig
everytime a devworkspace is loaded. This new API injects the kubeconfig into all containers associated with a devworkspaceId.What issues does this PR fix or reference?
eclipse-che/che#20782
Is it tested? How?
Ensure that Che is running with devworkspaces enabled then either create a new devworkspace from the dashboard itself or use
https://gist.githubusercontent.com/JPinkney/d4f6e665d1239a5fc4caefbe20bf4f56/raw/96faebbd51b3bba209f8a8de8b448327f385c779/a.yaml
with a factory url (that gist has vscode-kubernetes-tools and vscode-yaml pre-installed). Wait for the workspace to start and then observe that the kubeconfig is located at$HOME/.kube/config
. If you are using the gist with vscode-kubernetes-tools then you can also observe that the kubeconfig is automatically loaded into vscode-kubernetes-tools when you open up the side panel.Release Notes
Docs PR