-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scm): Always get raw content from scm resolver #321
Conversation
There is an open issue that Axios return JSON object even if we ask with text type Fix eclipse-che/che#20271
Add comments to make it JSONC compliant and not JSON compliant so it can unblock users using this devfile proper fix is at eclipse-che/che-dashboard#321
Add comments to make it JSONC compliant and not JSON compliant so it can unblock users using this devfile proper fix is at eclipse-che/che-dashboard#321
❌ E2E dashboard tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-321 |
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
==========================================
- Coverage 52.01% 51.99% -0.03%
==========================================
Files 148 148
Lines 5646 5649 +3
Branches 927 927
==========================================
Hits 2937 2937
- Misses 2432 2435 +3
Partials 277 277
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, benoitf, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Axios is returning a JSON object even if we specify a raw content
axios/axios#907
Need to workaround with a custom transformResponse
Also, provide a better error message to isolate the root cause
What issues does this PR fix or reference?
Fixes eclipse-che/che#20271
Release Notes
Docs PR