Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scm): Always get raw content from scm resolver #321

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Aug 10, 2021

What does this PR do?

Axios is returning a JSON object even if we specify a raw content
axios/axios#907
Need to workaround with a custom transformResponse

Also, provide a better error message to isolate the root cause

What issues does this PR fix or reference?

Fixes eclipse-che/che#20271

Release Notes

Docs PR

There is an open issue that Axios return JSON object even if we ask with text type
Fix eclipse-che/che#20271
benoitf added a commit to che-samples/java-spring-petclinic that referenced this pull request Aug 10, 2021
Add comments to make it JSONC compliant and not JSON compliant so it can unblock users using this devfile
proper fix is at eclipse-che/che-dashboard#321
benoitf added a commit to che-samples/java-spring-petclinic that referenced this pull request Aug 10, 2021
Add comments to make it JSONC compliant and not JSON compliant so it can unblock users using this devfile
proper fix is at eclipse-che/che-dashboard#321
@che-bot
Copy link
Contributor

che-bot commented Aug 10, 2021

❌ E2E dashboard tests failed ❗

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@github-actions
Copy link

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-321

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #321 (4a82107) into main (e9bac8a) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   52.01%   51.99%   -0.03%     
==========================================
  Files         148      148              
  Lines        5646     5649       +3     
  Branches      927      927              
==========================================
  Hits         2937     2937              
- Misses       2432     2435       +3     
  Partials      277      277              
Impacted Files Coverage Δ
...rc/services/workspace-client/devWorkspaceClient.ts 15.02% <0.00%> (-0.27%) ⬇️
...hboard-frontend/src/store/FactoryResolver/index.ts 18.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9bac8a...4a82107. Read the comment docs.

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, benoitf, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to start devworkspace with sample Java spring boot
4 participants