-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Force refresh personal access token #1137
Conversation
Signed-off-by: Anatolii Bazko <[email protected]>
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1137 +/- ##
==========================================
- Coverage 89.61% 89.58% -0.04%
==========================================
Files 411 411
Lines 41920 41976 +56
Branches 2809 2825 +16
==========================================
+ Hits 37566 37603 +37
- Misses 4329 4344 +15
- Partials 25 29 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1137 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1137", name: che-dashboard}]}}]" |
if (!project || !project.git) { | ||
return; | ||
} | ||
static async refreshTokenIfProjectExists(workspace: devfileApi.DevWorkspace): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tolusha I'm a bit lost, why project presence in devfile is indicator for token refresh ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the very least, would be great to have some comment with method description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a repository url to figure out the correct OAuth provider.
|
||
try { | ||
await refreshFactoryOauthToken(project.git.remotes.origin); | ||
if (project) { | ||
await refreshFactoryOauthToken(project.git!.remotes.origin); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it expected change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
/test v14-dashboard-happy-path |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.15 :: dashboard_3.15/2: Console, Changes, Git Data |
Build 3.16 :: dashboard_3.x/503: Console, Changes, Git Data |
Build 3.15 :: sync-to-downstream_3.15/10: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/6979: Console, Changes, Git Data |
Build 3.16 :: push-latest-container-to-quay_3.x/4693: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/6930: dashboard : 3.x :: Build 62237474 : quay.io/devspaces/dashboard-rhel8:3.16-2 |
Build 3.16 :: update-digests_3.x/6889: Console, Changes, Git Data |
Build 3.16 :: dashboard_3.x/503: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6979 triggered |
Build 3.16 :: operator-bundle_3.x/3125: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/6980: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/6931: devspaces-operator-bundle : 3.x :: Failed in 62237807 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
feat: Force refresh personal access token
What issues does this PR fix or reference?
eclipse-che/che#23005
Is it tested? How?
N/A
Release Notes
N/A
Docs PR
N/A