Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data resolver API #1052

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Fix data resolver API #1052

merged 3 commits into from
Feb 14, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Feb 14, 2024

What does this PR do?

Fix the error for data resolver API 'POST ${baseApiPath}/data/resolver'.

What issues does this PR fix or reference?

eclipse-che/che#22814

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.

  2. Open Swagger in the new tab.
    {CHE-server}/dashboard/api/swagger

  3. Request data resolver with the next payload:

{
  "url": "{CHE-server}/dashboard/devfile-registry/devfiles/index.json"
}

Знімок екрана 2024-02-14 о 14 07 44

The status code should be 200.

  1. Request data resolver with non-existence payload:
{
  "url": "{CHE-server}/dashboard/devfile-registry/devfiles/index111.json"
}

Знімок екрана 2024-02-14 о 14 01 33

The status code should be 404.

@che-bot
Copy link
Contributor

che-bot commented Feb 14, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1052

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1052", name: che-dashboard}]}}]"

@akurinnoy
Copy link
Contributor

/retest

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1052

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1052", name: che-dashboard}]}}]"

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (eba4a27) 88.43% compared to head (6bc6c37) 88.41%.

Files Patch % Lines
.../src/routes/api/helpers/getCertificateAuthority.ts 44.44% 5 Missing ⚠️
...dashboard-backend/src/services/logWatcher/index.ts 54.54% 5 Missing ⚠️
...s/dashboard-backend/src/routes/api/dataResolver.ts 83.33% 3 Missing ⚠️
...ard-backend/src/routes/api/workspacePreferences.ts 0.00% 3 Missing ⚠️
...es/dashboard-backend/src/routes/api/podmanLogin.ts 0.00% 1 Missing ⚠️
.../dashboard-backend/src/routes/workspaceRedirect.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
- Coverage   88.43%   88.41%   -0.03%     
==========================================
  Files         390      390              
  Lines       40058    40083      +25     
  Branches     2697     2704       +7     
==========================================
+ Hits        35427    35440      +13     
- Misses       4605     4617      +12     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olexii4
Copy link
Contributor Author

olexii4 commented Feb 14, 2024

/retest

Copy link

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 9f0a1c6 into main Feb 14, 2024
16 of 18 checks passed
@olexii4 olexii4 deleted the CHE-22814 branch February 14, 2024 17:05
@devstudio-release
Copy link

Build 3.12 :: dashboard_3.12/5: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.13 :: dashboard_3.x/458: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.13 :: dashboard_3.x/458: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6244 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: dashboard_3.12/5: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.12/108 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.12/109: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.12/106 triggered; /job/DS_CI/job/dsc_3.12 triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.12/70: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.12/109 triggered

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2493: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.13 :: sync-to-downstream_3.x/6245: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6173 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.13 :: operator-bundle_3.x/2668: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6245 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.12/6: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.12/100: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.12/70 triggered

@devstudio-release
Copy link

Build 3.13 :: copyIIBsToQuay/2494: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.13 :: update-digests_3.x/5874: SUCCESS

Detected new images: rebuild operator-bundle
* code
* dashboard; /DS_CI/operator-bundle_3.x/2668 triggered

@devstudio-release
Copy link

Build 3.13 :: dsc_3.x/1820: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: dsc_3.12/6: SUCCESS

3.12.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants