Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reviewing pull requests blog post #23

Merged
merged 2 commits into from
Feb 16, 2022
Merged

feat: reviewing pull requests blog post #23

merged 2 commits into from
Feb 16, 2022

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Feb 10, 2022 •
edited
Loading

@dkwon17 dkwon17 requested a review from ibuziuk February 10, 2022 18:15
dkwon17
dkwon17 commented Feb 10, 2022
View reviewed changes
_posts/2022-01-11-contributing-for-the-first-time-to-a-project.adoc
@@ -74,7 +74,7 @@ Now you are ready for the first contribution. For GitHub, a dedicated plugin is
image::/assets/img/contribute-to-a-project/github-plugin.png[[The 'GitHub' plugin]
{empty}

=== How can maintainers set up their projects to use {prod}?
=== How can maintainers set up their projects to use {prod}? [[set-up-project]]
Copy link
Contributor Author

@dkwon17 dkwon17 Feb 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[set-up-project]] was added so that this section can be linked here:

blog/_posts/2022-02-09-reviewing-pull-requests.adoc

Lines 21 to 23 in 0f35423

Please refer to these references on how to set up your project with {prod}:
* <<../../01/11/@ilya.buziuk-contributing-for-the-first-time-to-a-project#set-up-project,How can maintainers set up their projects to use Eclipse Che?>>

@dkwon17 dkwon17 requested review from benoitf, l0rd and themr0c February 10, 2022 18:23
@dkwon17 dkwon17 force-pushed the reviewing-pull-requests branch from 0f35423 to ef34674 Compare February 10, 2022 18:36
@ibuziuk ibuziuk mentioned this pull request Feb 11, 2022
Closed
@ibuziuk
Copy link
Member

ibuziuk commented Feb 11, 2022

@tstastna @themr0c please, review
we plan to have it published next week

ibuziuk
ibuziuk reviewed Feb 11, 2022
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great article, really like it
the only thing is that with che-incubator organization has enabled OAuth App access restrictions it is not possible to approve / merge PRs from IDE. I think we should consider disabling this restriction

@dkwon17 dkwon17 force-pushed the reviewing-pull-requests branch from ef34674 to abf3c7a Compare February 11, 2022 16:10
@dkwon17
Copy link
Contributor Author

dkwon17 commented Feb 11, 2022

@ibuziuk thank you for the review, I have pushed the latest changes.

ibuziuk
ibuziuk approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, David
could you please update the file so that the publication date will be Feb 16th
Would be great to have it published on the hump day next week 👍

@dkwon17 dkwon17 force-pushed the reviewing-pull-requests branch 2 times, most recently from 8f144db to bb665aa Compare February 12, 2022 01:23
@dkwon17 dkwon17 force-pushed the reviewing-pull-requests branch from bb665aa to 8304834 Compare February 12, 2022 01:33
@dkwon17
Copy link
Contributor Author

dkwon17 commented Feb 12, 2022

could you please update the file so that the publication date will be Feb 16th

Updated to Feb 16 👍

@themr0c
Copy link
Contributor

themr0c commented Feb 16, 2022

Is it OK to merge with the ECA failure? Else @dkwon17 would have to amend the commits in his branch to fix the email address.

@deerskindoll @ibuziuk
@themr0c @dkwon17
editing writing style and punctuation (#1)
3e3319e 
* editing writing style and punctuation

Signed-off-by: Jana Vrbkova <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Ilya Buziuk <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Ilya Buziuk <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Ilya Buziuk <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Ilya Buziuk <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: David Kwon <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Update 2022-02-16-reviewing-pull-requests.adoc

quick typo fix

Co-authored-by: Ilya Buziuk <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: David Kwon <[email protected]>
@dkwon17 dkwon17 force-pushed the reviewing-pull-requests branch from 679b42a to 3e3319e Compare February 16, 2022 16:30
@dkwon17 dkwon17 merged commit b4912b9 into eclipse-che:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@deerskindoll deerskindoll deerskindoll approved these changes

@themr0c themr0c themr0c approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd l0rd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dkwon17 @ibuziuk @themr0c @benoitf @deerskindoll