Add Critical path configuration menu and critical path view #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a thought. The time graph entry metadata for the thread status data provider has already the TID. It misses the hostId. Maybe, it's not necessary to retrieve the context if the host Id is provided as well. We could the have only the menu definition (coming from the server, once implemented) indicate that these parameter are meant to be included query parameters for other data providers. The only disadvantage is that the hostId is redundant and will increase the size of the data model return from fetchTree(). |
Note that code is hard-coded. A generic way is needed to configure the menu and command-handler driven by the server. Alternatively, this feature could be added in a third-party, trace compass specific front-end extension(s) (i.e. Theia extension/Vscode extension). Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
criticalPathJs
branch
from
440293b to
f93f1ed
Compare
|
PoC only, not needed at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that code is hard-coded. A generic way is needed to configure
the menu and command-handler driven by the server.
Alternatively, this feature could be added in a third-party, trace
compass specific front-end extension(s) (i.e. Theia extension/Vscode
extension).
Requires: https://github.com/eclipse-cdt-cloud/tsp-typescript-client/pull/104
Signed-off-by: Bernd Hufmann [email protected]