How to apply dataset filter expression while get parameter selection … #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list? eclipse-birt#1993 I added a boolean to enable/disable the normal data engine flow mode to apply filter expressions in datasets.
merks
reviewed
Dec 9, 2024
|
@merks I was not sure about it... that's why I implemented it microinversively. Can't find any places where the other modes (IV, DATA_EXTRACTION) will be used. But if it is useful to set these modes at this place, then i can change it. |
|
FYI I don't really know the APIs well. You're right that the other enumerators appear unused. So I'll wait for other folks to comment. Note that adding methods to API breaks the API so whatever we do here, I think it would be better to define default methods in the interface, which means the mock class needs no changes.... |
speckyspooky
requested changes
Dec 9, 2024
...e.birt.report.engine/src/org/eclipse/birt/report/engine/api/IGetParameterDefinitionTask.java
Outdated
Show resolved
Hide resolved
...e.birt.report.engine/src/org/eclipse/birt/report/engine/api/IGetParameterDefinitionTask.java
Outdated
Show resolved
Hide resolved
…list? eclipse-birt#1993 default methods added to IGetParameterDefinitionTask
speckyspooky
added
the
Enhancement
hvbtup
pushed a commit
to triestram-partner/birt
that referenced
this pull request
Feb 11, 2025
eclipse-birt#2005) I added a boolean to enable/disable the normal data engine flow mode to apply filter expressions in datasets. eclipse-birt#1993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…list? #1993
I added a boolean to enable/disable the normal data engine flow mode to apply filter expressions in datasets.