Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several dead links on Templates & Examples page (https://eclipse-birt.github.io/birt-website/docs/template-introduction) #1300

Open
gmkavuna opened this issue Jun 2, 2023 · 11 comments
Open

Several dead links on Templates & Examples page (https://eclipse-birt.github.io/birt-website/docs/template-introduction) #1300

gmkavuna opened this issue Jun 2, 2023 · 11 comments

Comments

@gmkavuna
Copy link

gmkavuna commented Jun 2, 2023

I hope this is the right report documentation issues. If not, please point me in the right direction. I noticed a number of dead links on https://eclipse-birt.github.io/birt-website/docs/template-introduction. Here is one example:

  1. XML Data Source​

View XML Data Source here.

image

image
@carehart
Copy link

carehart commented Feb 3, 2025 •
edited
Loading

This problem remains: incorrect links on that page, which is what's offered via the "templates" option of the top-level menu of the main birt site.

The results differ: now they all redirect to birt main site, https://eclipse-birt.github.io/birt-website/. That includes the link mentioned by the OP above (in 2023) and for any of them, starting with the first, "product catalog", which tries to go to https://www.eclipse.org/birt/phoenix/examples/solution/ProductCatalog.html but again simply redirects back to the site front page.

Indeed, it's as if some global rewrite changes anything URL starting with eclipse.org/birt to eclipse-birt.github.io/birt-website/, but it does it without regard to offering a CORRECT specific page to redirect to--nor does the rewrite distinguish between a legit previous link or not. For example, using https://www.eclipse.org/birt/bob also just redirects back to that front page.

Finally, if someone may say "just download the templates, as offered via the 'you can simply download all reports and their templates here' link on that page", sadly that fails also. The page it links to offers a link which itself also fails: https://eclipse-birt.github.io/static/templates/BIRT-templates-download_V4.9.zip. And there's no mention of any templates zip on the downloads page. I realize that could be raised as another issue, but I wanted to wait to see what the reply may be to this one.

@hvbtup
Copy link
Contributor

hvbtup commented Feb 4, 2025

@chloetz @wimjongman Shouldn't this be transferred to the birt-website repo?

Besides, I still think that the entry barriers to collaboration are too high. I'd prefer a GH wiki right here at the birt repo.

@chloetz
Copy link

chloetz commented Feb 4, 2025 via email

@merks
Copy link
Contributor

merks commented Feb 4, 2025

The main issue was that we asked to be able to withdraw committed code for some restricted time if any failure occurred on our side in committing the code accidently. “Erare humanum est” – well I guess in Eclipse’s community everybody is error free…

Wow, that's just such a special request. Of course you can't rewrite history for an open source project. Once something is in the history it must remain there. Moreover once committed it will be pulled into other clones across the planet, it will be built with source bundles that are published to the download server, mirrored across the planet, and downloaded by anyone on the planet. I.e., it will have escaped and be free in the wild with the EPL 2.0 license. So it's kind of a ridiculous request that cannot be realistically implemented. We live in a glass house and our mistakes are seen by the world. It's not an issue that in Eclipse community everybody is error free, it's simply not possible to erase errors as if the error never happened, errors can only be corrected.

@wimjongman
Copy link
Contributor

I have been excluded as an Eclipse committer as my company doesn’t agree on Eclipse’s “new” committer agreements. I feel sorry for this but cant change it.

I'm sure your company is still happy to consume Eclipse open source?

@chloetz
Copy link

chloetz commented Feb 4, 2025 via email

@chloetz
Copy link

chloetz commented Feb 4, 2025 via email

@merks
Copy link
Contributor

merks commented Feb 4, 2025

Hi Ed, well, I think you haven’t read my request carefully enough.

I read "withdraw committed code" literally as stated.

I understand your argumentation and it is completely correct, but if you detect an error while transporting your code to Eclipse you may want to with draw it or in other words not commit the transaction.

That's worded differently. This doesn't suggest to be able to "withdraw a commit" but rather to "not commit the transaction". I don't know exactly what a "transaction" is, but a "commit" is well defined...

The case I discussed with Eclipse some years ago was that code which is not under discloser might be transported accidentally.

"Transported" also is not so well defined in my mind. Maybe that's like wanting to unsend an already-sent email?

This brings the committer in a terrible situation as he now personally responsible towards his employer and could mean his personal insolvency although that he detects his error while transporting the code to Eclipse.

I'd not like to work for your employer. I wonder now though, the concern you state here is a personal one relative your relation with your company but you represented the issue originally as "my company doesn’t agree".

I believe it is good practice not to describe suggestions of third parties as ridiculous, but rather to ask why a proposition is made, so that a common understanding of the issue can emerge. With all my respectful regards

Yes, sorry for calling it "kind of ridiculous" rather than simply pointing out that it's effectively impossible to transform an actual commit into something that never happened. Aborting transactions or undoing transports is something else, but I have no idea concretely to what that might refer. The content of a PR maybe? Even a PR can have been applied before was deleted, if such deletion were permitted...

While looking at best practices I will assume that saying "I guess in Eclipse’s community everybody is error free" is meant as tongue-in-cheek satire rather than a obliquely insulting comment that somewhat misrepresents the problem space.

@chloetz
Copy link

chloetz commented Feb 4, 2025 via email

@merks
Copy link
Contributor

merks commented Feb 4, 2025

@chloetz

😀

I googled a bit:

https://stackoverflow.com/questions/8834755/github-pull-request-from-private-to-public-repo-possible

I think if you diligently managed forks/private-clones internally at your own organization's end (which is really not expensive and not complicated) to create carefully-reviewed commits and ultimately a public pull request, you could achieve what you want without requiring process changes at the receiving end. It's just not realistic to expect the well-established development processes that work for hundreds of member organizations currently, including many multi-billion dollar/euro corporations, to adapt to this level of carefulness.

@chloetz
Copy link

chloetz commented Feb 4, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@wimjongman @merks @carehart @hvbtup @gmkavuna @chloetz