This repository has been archived by the owner on May 7, 2020. It is now read-only.
Fix OneWire bridge handler test #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henning Treu <[email protected]>
|
Theoretically the status update from the scheduled task could also be executed before the thing status is set to unknown: If it's set to unknown before the connection is started, the order should be guaranteed. I see you fixed that. 👍 Perhaps the archetype should also be updated: |
|
LGTM. And I agree with @wborn, the archetype should be updated, too. |
Signed-off-by: Henning Treu <[email protected]>
wborn
reviewed
Sep 6, 2018
| @@ -80,20 +80,22 @@ public void initialize() { | |||
| // access or similar) you should set status UNKNOWN here and then decide the real status asynchronously in the | |||
| // background. | |||
|
|
|||
| // set the thing status to UNKNOWN temporarily and let the background task decide for the real status. | |||
| // the framework is then able to reuse the resources from the thing handler initialization. | |||
| // we set this upfront to reliably check status updste sin unit tests. | |||
There was a problem hiding this comment.
Besides this "updste sin" typo the PR looks good! 👍
Signed-off-by: Henning Treu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses occasionally failing tests, see #6153 (comment)
Signed-off-by: Henning Treu [email protected]