-
Notifications
You must be signed in to change notification settings - Fork 781
Test ESH with Java 9/10/11 #4369
Comments
A nightly Build openHAB 2.2, started in Debian 7 jessie with oracle 9 SDK:
Nothing extraordinary happens in the log files. |
@lewie, we have to keep ESH separate from openHAB. openHAB clearly isn't yet ready, due to lacking Java 9 support in Karaf - we should track that rather in openhab-distro. For ESH, it all looks better. The exception in the log above is from Jetty, which we also use in the ESH IDE for development - version 9.3.16 has this fixed, so it might be worth to update this on the ESH targetplatform. |
FTR, @wborn made some tests with openHAB (using Karaf 4.2.1) on Java 9+10 in openhab/openhab-distro#761. The only issue that came up so far wrt ESH is x-stream/xstream#101. I am not clear whether there is anything we could change in our use of Xstream (probably not?) or if we will have to live with JVM arguments to simply allow such illegal accesses (not clean). |
FTR: I tested an ESH based solution with Java 9, too. Till now it is working. |
How do you avoid the warnings that are caused by Xstream? |
I assume you refer to this one:
I just don't care about that warning as it still works. |
🙄 Do you proceed that way with all warnings that you come across...? |
Yes, I refer to the one that I had mentioned just above your comment: #4369 (comment):
|
The warning states that the access operation will be denied in a future release. AFAIK and as you comment in the linked commit for another warning:
you just don't show the warning to the user which is very similar then ignoring it. |
Ok, I have updated the title 😛 . Actually, Java 9 is EOL since 6 months already and support for Java 10 will cease end of this month. So what we should be looking at is actually Java 11. Hence I don't think we should simply ignore such warnings.
Because this warning is evaluated and accepted by the solution provider. Thus the solution users should not be bothered. Same situation here: If we say we are ok with the way it runs on Java 9, we would not want to bother our users with that warning - as they might be alarmed and enter issues about it. |
Same is true for the product I referred. |
You lucky one ;-) |
I tested Eclipse SmartHome running with JDK 11 in the IDE. Here are the current issues that I found: With
|
Furthermore there are a lot of The REST interface however performs just normal. So I'm not sure how severe those warnings are. HK2 dependency injection seems to be the root of this. AFAIK it's not meant to be disabled in jersey.
|
@kaikreuzer Why using XStream at all? |
@maggu2810 I cannot remember the details of the decision, this contribution is already very long ago... |
Just as a reminder to ourselves: Now that Java 9 is out, we should make sure that ESH runs smoothly on it as well. (Note that this does not mean that we will move the code base from 8 to 9 any time soon - we should simply try to increase the number of JVMs that ESH can run on).
The text was updated successfully, but these errors were encountered: