Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

SVT: Missing files error when importing some Appsody projects (VS code) #488

Closed
sujeilyfonseca opened this issue Sep 19, 2019 · 9 comments
Closed
Labels
area/appsody Appsody in Codewind kind/bug

Comments

@sujeilyfonseca
Copy link

Codewind version: 0.4.0
OS: Windows 10 and MacOS Mojave (10.14.6)

IDE extension version: 0.4.0
IDE version: 1.38.1

Description: In VS Code, users are requested to confirm the type and language of the project to be imported. However, the types are always incorrect and if the user selects “yes”, the import will fail due to missing files. This error occurs with all Appsody projects, except Appsody Eclipse MicroProfile and Appsody Python Flask. These latest templates currently do not automatically detect any information from the imported project.

Screen Shot 2019-09-18 at 5 00 44 PM

Screen Shot 2019-09-18 at 5 00 56 PM

Screen Shot 2019-09-18 at 5 05 56 PM

Screen Shot 2019-09-18 at 5 06 19 PM

Screen Shot 2019-09-18 at 5 08 12 PM

Screen Shot 2019-09-18 at 5 08 21 PM

Screen Shot 2019-09-18 at 5 08 53 PM

Screen Shot 2019-09-18 at 5 09 05 PM

Screen Shot 2019-09-18 at 10 03 40 PM

Screen Shot 2019-09-18 at 10 28 30 PM

Screen Shot 2019-09-18 at 10 33 28 PM

Screen Shot 2019-09-18 at 10 31 56 PM

Screen Shot 2019-09-18 at 9 57 56 PM

Screen Shot 2019-09-18 at 10 29 28 PM

Steps:

  1. Install Codewind
  2. Start Codewind
  3. Create an Appsody project
  4. Remove the created project from Codewind
  5. Import the project

Workaround: Manually change the project type to appsodyExtension.

@jagraj

@tobespc tobespc added area/appsody Appsody in Codewind area/vscode-ide Issue associated with the Codewind VS Code/Theia extension labels Sep 19, 2019
@makandre
Copy link
Contributor

makandre commented Sep 19, 2019

This is basically same as #445 (for which there is a PR to fix: eclipse-archived/codewind-installer#126)

@tetchel tetchel removed the area/vscode-ide Issue associated with the Codewind VS Code/Theia extension label Sep 19, 2019
@tetchel
Copy link

tetchel commented Sep 19, 2019

The vs code behaviour is correct; portal is providing bad info, and the user will likely not know better than to override it (by selecting "No, this is not the correct type" and then selecting Appsody)

tetchel pushed a commit to tetchel/codewind-vscode that referenced this issue Sep 19, 2019
jopit pushed a commit to eclipse-archived/codewind-vscode that referenced this issue Sep 19, 2019
@sujeilyfonseca
Copy link
Author

I tested this problem on 2019-09-19. Users may not encounter this problem frequently, as Appsody projects are now being detected correctly. However, if the user selects "No" in the confirmation window and then enters the same type and language, he/she will get the error presented above regarding the missing files. For example, if the project type appears in the confirmation window as "appsodyExtension" and the project language as "java", and you enter the exact information manually, you will get the missing files error.

@makandre
Copy link
Contributor

@tetchel there were some language selection bug in IDE that was fixed I believe?

@tetchel
Copy link

tetchel commented Sep 19, 2019

yes, that was #486 - this new issue is separate, for if the user chooses to ignore the autodetection even though it is correct.

@tetchel
Copy link

tetchel commented Sep 19, 2019

I expect it has something to do with the installer tracking isAppsody separately in its detection logic, ie isAppsody is not necessarily the same as projectType == "appsodyExtension" ? but I just took a quick look at that code

@makandre
Copy link
Contributor

isApposdy was only used inside the installer to keep track of whether they need to run init. It's not returned to IDE (and it's going away post-0.4)

@tetchel
Copy link

tetchel commented Sep 19, 2019

ok, if this behaviour is changing in 0.5 i think we should consider this issue good for now (since it doesn't make much sense for a user to ignore the correct autodetection), and verify the new behaviour when it's in?

@makandre
Copy link
Contributor

This has been fixed for a while. Can we close?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/appsody Appsody in Codewind kind/bug
Projects
None yet
Development

No branches or pull requests

4 participants