This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Install appsody as prereq to installer #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mak <[email protected]>
|
This is the PR to copy appsody CLI alongside codewind installer CLI. Initially it was discussed we should zip up the appsody binary. But we did not do this because we wanted to quickly piggyback on what's currently done with the codewind binary (it is not zipped up). Ultimately we would want to dynamically fetch both appsody and codewind CLIs so they are not bundled into the repo. So we opted to leave out the zipping since that's going to add some complexity that would be tossed out soon anyways. @tetchel Could you review please? |
|
I'm concerned that this adds about 40MB to the size of the plugins. I'd really like us to find some way to make this smaller. |
Signed-off-by: Andrew Mak <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Mak [email protected]
For eclipse-archived/codewind#271