Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

[985][2647] Manage Secure and Non-Secure Template Sources #137

Conversation

keithchong
Copy link
Contributor

@keithchong keithchong commented Jun 23, 2020

Signed-off-by: Keith Chong [email protected]

What type of PR is this ?

  • Bug fix
  • Enhancement

What does this PR do ?

Enhancement to support managing secure and non-secure template source repos

Which issue(s) does this PR fix ?

eclipse-archived/codewind#985
eclipse-archived/codewind#2647
eclipse-archived/codewind#3161 (but for IntelliJ)

Does this PR require a documentation change ?

Yes, see 985 and 2647

Any special notes for your reviewer ?

  • This change adds wizard framework changes to support different wizard page 'paths', although eventually, we reduced it down to a simple two page wizard for Adding a new template source.
  • This change includes a fix to handle 404 when creating a new project (revealed by testing secure template repos). See CodewindModuleBuilder and SetupCodewindProjectRunnable
  • This change also includes a fix for [Eclipse] Prevent duplicate template source URLs from being added codewind#3161 but for IntelliJ
  • See 985 for screenshots

@keithchong keithchong self-assigned this Jun 23, 2020
@keithchong keithchong requested a review from jopit June 23, 2020 15:48
@keithchong keithchong force-pushed the 985-ManageSecureAndNonSecureTemplateSource branch from 6d29baa to 5e29ccb Compare June 23, 2020 20:45
@keithchong
Copy link
Contributor Author

Hi @jopit , I removed the log statements.

@jopit jopit merged commit 1aaeadd into eclipse-archived:master Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants