Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

0.3.1remove images #110

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Conversation

tobespc
Copy link
Contributor

@tobespc tobespc commented Sep 6, 2019

fix for the shutting down of containers when closing codewind

eclipse-archived/codewind#389

Copy link
Contributor

@hhellyer hhellyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Should be the minimum changes to remove the correct images.

Copy link
Contributor

@hhellyer hhellyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good but allows for Andrews feedback on #108 (the same fix in master)

@tobespc tobespc merged commit c52f3e5 into eclipse-archived:0.3.1 Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants