This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Removing dist/images folder, renaming image paths #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Ishida <[email protected]>
sghung
suggested changes
Feb 28, 2020
There was a problem hiding this comment.
In the README remove the mention of the 'dist' folder now that we're getting rid of it. Need to update what images is about too, since it contains ALL the images now. The two bullet points below is what is CURRENTLY in the readme and needs to be changed:
dist- The folder that contains some of the static images.images- Also contains some of the docs static images. We need to split images into two folders, one for images in any document created by the documentation team and another for images on the landing page. See issue ID: Move Codewind content images to dist/images codewind#1883.
Besides that, everything else looks good. I opened a few of the affected pages and verified the images worked. In addition, used the chrome inspector to ensure it isn't using the dist directory anymore. I also ran build.sh to ensure there are no broken links
sghung
approved these changes
Feb 28, 2020
jcockbain
pushed a commit
to jcockbain/codewind-docs
that referenced
this pull request
May 26, 2020
Signed-off-by: Sarah Ishida <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarah Ishida [email protected]
PR for eclipse-archived/codewind#1883