Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Adding Configuring template repos #143

Merged
merged 11 commits into from
Sep 19, 2019
Merged

Adding Configuring template repos #143

merged 11 commits into from
Sep 19, 2019

Conversation

sishida
Copy link
Contributor

@sishida sishida commented Sep 17, 2019

Signed-off-by: Sarah Ishida [email protected]

Update for eclipse-archived/codewind#32 and eclipse-archived/codewind#434.

There's not much to this PR right now, but hopefully we can add more to this page if/when the UI evolves. Feel free to suggest any other additions if you have them. Thanks!

@sishida sishida requested a review from tetchel September 17, 2019 16:38
@sishida sishida self-assigned this Sep 17, 2019
@tetchel
Copy link

tetchel commented Sep 17, 2019

Well, I think we're more interested in explaining here what "template repositories" actually are?

@tetchel
Copy link

tetchel commented Sep 17, 2019

also, eclipse has the same feature.

@sishida
Updating based on feedback
cfb2da7 
Signed-off-by: Sarah Ishida <[email protected]>
@sishida
Editing based on feedback
e26e7d0 
Signed-off-by: Sarah Ishida <[email protected]>
@sishida
Adding content for Eclipse
b9fe521 
Signed-off-by: Sarah Ishida <[email protected]>
@sishida
Merge branch 'sishida_32_templatemanaging' of github.com:sishida/code…
4698163 
…wind-docs into sishida_32_templatemanaging

Adding content for Eclipse.
@sishida
Copy link
Contributor Author

sishida commented Sep 17, 2019 •
edited
Loading

@tetchel

  • Added sentence about template repositories.
  • Removed outdated line 24.

@eharris369

  • I added content about managing template repos in the Eclipse file. I based the content on VS Code content--just want to make sure it matches with Eclipse.

@sishida sishida requested a review from eharris369 September 17, 2019 20:08
@tetchel
Copy link

tetchel commented Sep 17, 2019

Everything above line 24 is outdated not just that particular line. Except for

When you create a new project, you can choose from the default set of templates available, or you can choose from a template repository of your own.

which is still accurate

@sishida
Removing outdated info
cb6b3d7 
Signed-off-by: Sarah Ishida <[email protected]>
@sishida
Copy link
Contributor Author

sishida commented Sep 18, 2019

@tetchel and @eharris369 I have removed the outdated info. Sorry about my misunderstanding! 😅

@tetchel
Copy link

tetchel commented Sep 18, 2019

One other correction is that we have moved from calling them "template repositories" to "template sources". Similarly, the action to open the Manage page is called Manage Template Sources in VS Code.

@sishida
Editing based on feedback
0c517d3 
Signed-off-by: Sarah Ishida <[email protected]>
@sishida
Copy link
Contributor Author

sishida commented Sep 18, 2019

@tetchel and @eharris369 Hi, team,

Erin, I have addressed your latest comments in my new commit.

Also, I have asked Guy for review. Let's go ahead and merge if the content looks OK and then I'll create a new PR if Guy asks for any changes.

@sishida
Editing based on feedback
a8e4bc6 
Signed-off-by: Sarah Ishida <[email protected]>
@sishida
Copy link
Contributor Author

sishida commented Sep 19, 2019

@eharris369 Latest comment has been addressed! :)

eharris369
eharris369 approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@eharris369 eharris369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eclipse file looks good now.

@sishida
Copy link
Contributor Author

sishida commented Sep 19, 2019

@tetchel I have added a new commit! :)

@sishida
Edits based on feedback.
bcff491 
Signed-off-by: Sarah Ishida <[email protected]>
tetchel
tetchel approved these changes Sep 19, 2019
View reviewed changes
Copy link

@tetchel tetchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start, we are still totally lacking documentation for how to create your own template source repository (ie, provide your own index.json), but that's out of scope for this release. We should create a new issue for that.

@sishida sishida mentioned this pull request Sep 19, 2019
Closed
@sishida sishida merged commit 883e947 into eclipse-archived:master Sep 19, 2019
@sishida sishida deleted the sishida_32_templatemanaging branch September 19, 2019 17:44
@sishida
Copy link
Contributor Author

sishida commented Sep 19, 2019

@tetchel Good idea. I have opened eclipse-archived/codewind#497.

@AndyRWatson
Copy link

we also need to document how you create a template in your own template repository eclipse-archived/codewind#713

jcockbain pushed a commit to jcockbain/codewind-docs that referenced this pull request May 26, 2020
@sishida
Adding Configuring template repos (eclipse-archived#143)
6ba3c1d 
* Adding Configuring template repos

Signed-off-by: Sarah Ishida <[email protected]>

* Updating based on feedback

Signed-off-by: Sarah Ishida <[email protected]>

* Removing outdated info

Signed-off-by: Sarah Ishida <[email protected]>

* Editing text based on feedback

Signed-off-by: Sarah Ishida <[email protected]>

* Editing  based  on feedback

Signed-off-by: Sarah Ishida <[email protected]>

* Editing based on feedback

Signed-off-by: Sarah Ishida <[email protected]>

* Adding clarification based on feedback.

Signed-off-by: Sarah Ishida <[email protected]>

* Edits based on feedback.

Signed-off-by: Sarah Ishida <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eharris369 eharris369 eharris369 approved these changes

@tetchel tetchel tetchel approved these changes

Assignees

@sishida sishida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sishida @tetchel @AndyRWatson @eharris369