Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Define repo on add/remove commands + guarding #57

Merged
merged 11 commits into from
Nov 4, 2019

Conversation

makandre
Copy link
Contributor

@makandre makandre commented Nov 1, 2019

Part of eclipse-archived/codewind#564
This PR should be the last to go in to enable the functionality, after eclipse-archived/codewind-installer#179 and eclipse-archived/codewind#877

Also contains guarding for eclipse-archived/codewind#946

Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
@sghung sghung self-requested a review November 4, 2019 17:25
Copy link
Contributor

@sghung sghung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Tested by adding repo: https://github.com/appsody/stacks/releases/download/vertx-v0.1.4/experimental-index.json and then removing. Tested adding new project from the incubator and experimental repo into codewind.

@sghung sghung merged commit b72b7cf into eclipse-archived:master Nov 4, 2019
@makandre makandre deleted the repo2 branch November 4, 2019 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants