Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORT Server version information is wrong #1610

Closed
sschuberth opened this issue Dec 10, 2024 · 6 comments · Fixed by #1611
Closed

ORT Server version information is wrong #1610

sschuberth opened this issue Dec 10, 2024 · 6 comments · Fixed by #1611
Labels
ci CI related tasks.

Comments

@sschuberth
Copy link
Contributor

Although the latest tag is 0.1.0-RC6, both the recently published images and the UI display something prefixed with "0.0.1-RC.001..."

image

image

The SHA1s seem to be recent, though.
@sschuberth sschuberth added bug ci CI related tasks. labels Dec 10, 2024
@mnonnenmacher
Copy link
Contributor

The tagged images at least show the correct versions, e.g.:

ORT Server: 0.1.0-RC6
ORT Core: 42.0.0

@sschuberth
Copy link
Contributor Author

The tagged images at least show the correct versions

Sorry, where exactly are these correct versions shown?

@mnonnenmacher
Copy link
Contributor

The tagged images at least show the correct versions

Sorry, where exactly are these correct versions shown?

In the UI about screen.

@sschuberth
Copy link
Contributor Author

In the UI about screen.

Ah, ok. So it's correct (for you) when using a tagged image exactly. It's probably wrong for us when deploying main as we probably to not fetch tags along with the branch, so that the version can be calculated correctly relative to the latest tag.

@mnonnenmacher
Copy link
Contributor

mnonnenmacher commented Dec 10, 2024 •
edited
Loading

I just tested with the most recent image and see the same problem. Could the fix be to make sure that the Docker build job fetches the tags from the repository? Because my local builds work correctly.

mnonnenmacher added a commit that referenced this issue Dec 10, 2024
@mnonnenmacher
ci(docker): Fix calculating the ORT Server version
821301d 
Set `fetch-depth` to `0` to checkout the whole commit history including
tags. This is required to correctly calculate the ORT Server version.

Fixes #1610.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher mentioned this issue Dec 10, 2024
Merged
@sschuberth
Copy link
Contributor Author

Could the fix be to make sure that the Docker build job fetches the tags from the repository?

I guess so, yes.

github-merge-queue bot pushed a commit that referenced this issue Dec 10, 2024
@mnonnenmacher
ci(docker): Fix calculating the ORT Server version
45ee190 
Set `fetch-depth` to `0` to checkout the whole commit history including
tags. This is required to correctly calculate the ORT Server version.

Fixes #1610.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher removed the bug label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci CI related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(docker): Fix calculating the ORT Server version eclipse-apoapsis/ort-server
2 participants
@sschuberth @mnonnenmacher