Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ssp output #6

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Update ssp output #6

merged 2 commits into from
Aug 26, 2022

Conversation

apcraig
Copy link

@apcraig apcraig commented Aug 25, 2022

This updates the SSP output for testing and validation.

@apcraig
Copy link
Author

apcraig commented Aug 25, 2022

This output clearly shows a problems with the input data. The SSP data read in from the file is ordered differently than the data in the 5x5 test table. My guess is that the 5x5 test table is wrong as that would mean the snicar_5bnd_snow_short.text file is correct as defined. I'll need to reorder the data statement to match up with the order the arrays are defined in the code.

@apcraig
Copy link
Author

apcraig commented Aug 26, 2022

I updated the SNICAR SSP data statement and the data order now seems consistent with the bigger table that is read in by the icepack driver. I am fairly confident that both are now correct. Some sample output is written to the log file and could be checked with the experts, that looks like

 # Big table in file
 (icepack_init_radiation) nmbrad_snicar =     1471
 (icepack_init_radiation) nspint =        5
 (icepack_init_radiation) ssp_snwextdr(    1,    1) =   55.65840
 (icepack_init_radiation) ssp_snwextdr(    5,    1) =   57.30311
 (icepack_init_radiation) ssp_snwextdr(    1, 1471) =   1.092800
 (icepack_init_radiation) ssp_snwextdr(    5, 1471) =   1.095214

 # Test data 5x5
 (icepack_init_radiation) nmbrad_snicar =        5
 (icepack_init_radiation) nspint =        5
 (icepack_init_radiation) ssp_snwextdr(    1,    1) =   46.27375
 (icepack_init_radiation) ssp_snwextdr(    5,    1) =   47.48598
 (icepack_init_radiation) ssp_snwextdr(    1,    5) =   1.196168
 (icepack_init_radiation) ssp_snwextdr(    5,    5) =   1.198974

@apcraig
Copy link
Author

apcraig commented Aug 26, 2022

I have run some tests, the dEdd_snicar option still fails at run time. But I think this should be merged.

@eclare108213
Copy link
Owner

I haven't connected the proper forcing data for the dEdd_snicar option yet, so it isn't expected to run. This PR will definitely help with that task. Thank you!

@eclare108213 eclare108213 merged commit 1d6eaa6 into eclare108213:snicar Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants