Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt/asking for vote #2927

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Nt/asking for vote #2927

merged 6 commits into from
Oct 16, 2024

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

Request to vote Ecency proposal, asking only those mobile app user who have not yet voted. Support for dismissing request forever, or remind in 3 days in case do dismissal

Limitation
The overall experience did not turn out to be how I share the mockup that showed message of courtesy after voting, but settled for only "Thank you" message.
It started taking a lot more time when attempted to fine the behaviour but since it actually a part of flashList, it's not giving me luxury to easily fine tine. However, later we can convert this component to support announcements as well and make it more stable by spending more time to it. right now it does seem worth to spend more time on a component that would only appear once to user.

Screenshots/Video

Screen.Recording.2024-10-16.at.14.28.45.mov

@noumantahir noumantahir requested a review from feruzm October 16, 2024 09:34
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit a757f5a into development Oct 16, 2024
@feruzm feruzm deleted the nt/asking-for-vote branch October 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants