Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt/tab view migration #2923

Merged
merged 8 commits into from
Sep 27, 2024
Merged

Nt/tab view migration #2923

merged 8 commits into from
Sep 27, 2024

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

Replaced ScrollableTabView completely in favour of more maintained react-native-tab-view

The UI of tab bar is different from what was implemented before, let me know if it's important to retain previous tab bar behaviour.

Screenshots/Video

Screen.Recording.2024-09-27.at.18.13.21.mov

@noumantahir noumantahir requested a review from feruzm September 27, 2024 13:14
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 17be69d into development Sep 27, 2024
@feruzm feruzm deleted the nt/tab-view-migration branch September 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants