Nt/beneficiary extraction #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
Based on my assessments, apparently it is not sorting that was causing the issue but having duplicate beneficiary possibly returned in videoMetadata as we do also inject one default beneficiary manually as well.
Moreover my forced duplication test also produced expected error based on my assessment above. message only talks about sorting order and not pointing toward duplication, which is the issue with my test case.
Updated makeOptions method to discard any duplicated beneficiary along with sorting them out.
Also, this PR handle the passing of already extracted beneficiaries to schedule post routing.
Issue number
https://discord.com/channels/@me/920267778190086205/1277127392997146665
Screenshots/Video
Successful publishing of same draft that was failing with existing code.
