Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/poll fix #2897

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Nt/poll fix #2897

merged 4 commits into from
Jul 17, 2024

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

  • avoid setting wrong contentType if poll is empty
  • ignores empty pollDraft entry, keep poll bar indicator disabled in case of empty poll
  • removed POLL status of already published posts with empty data

@noumantahir noumantahir requested a review from feruzm July 17, 2024 10:35
feruzm
feruzm approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 3a2ab9e into development Jul 17, 2024
@feruzm feruzm deleted the nt/poll-fix branch July 17, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noumantahir @feruzm