Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved waves delete routine #2893

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Improved waves delete routine #2893

merged 2 commits into from
Jul 8, 2024

Conversation

aliseyalvi
Copy link
Collaborator

What does this PR?

In this PR I had improved waves delete routine by removing the need to iterating whole query and picking the query data directly based on parent permlink of wave post

Issue number

#2888

Screenshots/Video

@aliseyalvi aliseyalvi requested review from feruzm and noumantahir July 7, 2024 16:01
Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm... much better now

@feruzm feruzm merged commit 9b6e481 into development Jul 8, 2024
@feruzm feruzm deleted the sa/improve-wave-delete branch July 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants