Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed conflicting eslint parser #2882

Merged
merged 4 commits into from
May 31, 2024
Merged

removed conflicting eslint parser #2882

merged 4 commits into from
May 31, 2024

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented May 29, 2024 •
edited
Loading

What does this PR?

  • fixed conflicting lint parser issue
  • Sadaqat working fixing pending lint issues

Screenshots/Video

Screenshot 2024-05-29 at 12 31 42

@noumantahir noumantahir marked this pull request as ready for review May 31, 2024 10:10
@noumantahir noumantahir requested a review from feruzm May 31, 2024 10:10
feruzm
feruzm approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 64d9a86 into development May 31, 2024
@feruzm feruzm deleted the nt/recover-lint branch May 31, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliseyalvi aliseyalvi aliseyalvi left review comments

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noumantahir @feruzm @aliseyalvi