[Improve] Login Screen UI Update #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed commented code
|
|
@noumantahir fixed this issue as well |
noumantahir
reviewed
Dec 5, 2023
| return ( | ||
| <View style={[styles.dividerContainer, containerStyle]}> | ||
| <View style={[styles.divider, styles.leftDivider]} /> | ||
| <Text style={styles.orText}>OR</Text> |
noumantahir
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Check how the input skips characters some times... this has been there for quite some time now... if we are improving Login, I think this can be addressed as well...
Screen.Recording.2023-12-05.at.15.58.22.mov
Do also check one comment in PR thread. Other than that I think we can wrap this up and move to signup screen next.
* fixed character skipping issue due to debounce method and updated debounce logic
Monosnap.screencast.2023-12-11.15-27-12.mp4 |
feruzm
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
Updated login sceen UI according to ecency web login UI
Where should the reviewer start?
Go to Login Screen on mobile app and check updated UI
Issue number
fixes #2793
Screenshots/Video