Nt/wave image ratios #2760
Merged
Nt/wave image ratios #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
waves image_ratio support in json_metadata, will be great to have this data injected from web created waves as well to make overall waves exploring smooth.
Issue number
https://github.com/orgs/ecency/projects/2#card-90366283
Screenshots/Video
In demo video the first wave image appeared with default size even while the image itself was cached, such images were causing glitch while rendering...
In comparison, the
DEV TEST!(3rd post in video) from demo.com appeared wellformed without bordershttps://github.com/ecency/ecency-mobile/assets/6298342/ec180291-8b32-48e4-ba4d-3c54d9e5c697