Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #2745 add support of repeat transfer #2749

Merged
merged 5 commits into from
Sep 13, 2023
Merged

feat: #2745 add support of repeat transfer #2749

merged 5 commits into from
Sep 13, 2023

Conversation

gamingumar
Copy link
Collaborator

@gamingumar gamingumar commented Sep 6, 2023 •
edited
Loading

What does this PR?

Add repeat transfer feature

Where should the reviewer start?

Repeat Transfer button added in Wallet Screen

Issue number

#2745

Screenshots/Video

ecency-repeat-transfer.mp4

@gamingumar gamingumar changed the title feat: GU-2745 add support of repeat transfer feat: #2745 add support of repeat transfer Sep 6, 2023
@gamingumar gamingumar mentioned this pull request Sep 6, 2023
Open
2 tasks
noumantahir
noumantahir requested changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@noumantahir noumantahir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos! overall great job making your way around the code, left some comments in code, functionality wise we are good.

Just need some code cleaning and we should be good...

src/screens/assetDetails/children/activitiesList.tsx Outdated Show resolved Hide resolved
src/screens/assetDetails/screen/assetDetailsScreen.tsx Outdated Show resolved Hide resolved
src/screens/assetDetails/screen/assetDetailsScreen.tsx Outdated Show resolved Hide resolved
src/screens/transfer/screen/transferScreen.js Outdated Show resolved Hide resolved
src/components/basicUIElements/view/walletLineItem/walletLineItemView.tsx Outdated Show resolved Hide resolved
@noumantahir
Copy link
Collaborator

  • One test we can try is to check how app would response in case of initialAmount from repeat activity exceeding available asset balance

@gamingumar
Copy link
Collaborator Author

  • One test we can try is to check how app would response in case of initialAmount from repeat activity exceeding available asset balance

added alert now, let me know if we should change this message

@noumantahir
Copy link
Collaborator

noumantahir commented Sep 12, 2023 •
edited
Loading

Screenshot 2023-09-12 at 12 31 05 PM

Screenshot 2023-09-12 at 12 32 04 PM

Screenshot 2023-09-12 at 11 58 35 AM

noumantahir
noumantahir reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@noumantahir noumantahir requested a review from feruzm September 13, 2023 11:07
feruzm
feruzm approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit baa11fd into ecency:development Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noumantahir noumantahir noumantahir approved these changes

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gamingumar @noumantahir @feruzm