Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace colorpicker icon with ColorSwatch #4350

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Dec 29, 2023

It makes sense to use the swatch, as it also shows the contrast color.

Before:
Bildschirmfoto 2023-12-29 um 21 11 21

After:
Bildschirmfoto 2023-12-29 um 21 10 46

@manuelmeister manuelmeister added type: Frontend UX/UI deploy! Creates a feature branch deployment for this PR labels Dec 29, 2023
Copy link

github-actions bot commented Dec 29, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@carlobeltrame carlobeltrame added this pull request to the merge queue Jan 2, 2024
Merged via the queue into ecamp:devel with commit 308faad Jan 2, 2024
@manuelmeister manuelmeister deleted the feature/replace-colorpicker-icon-with-swatch branch January 2, 2024 21:18
Copy link

sentry-io bot commented Jan 10, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Could not parse #00000 as a color. Missing a plugin? contrastColor(src/common/helpers/colors) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR type: Frontend UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants