Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to set the login text key in dev and feature branch deployments #4020

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

carlobeltrame
Copy link
Member

Previously "dev" was the default for this value, but we changed it to "prod" for the go live. Dev and feature branch deployments haven't had the need to specify this value, but now they do.

…ch deployments

Previously "dev" was the default for this value, but we changed it to "prod" for the go live. Dev and feature branch deployments haven't had the need to specify this value, but now they do.
@carlobeltrame carlobeltrame requested a review from BacLuc October 23, 2023 11:27
@BacLuc BacLuc added the deploy! Creates a feature branch deployment for this PR label Oct 23, 2023
@carlobeltrame
Copy link
Member Author

Deploying this feature branch probably won't work, because the feature branch deployment workflow is still read from the devel branch

@BacLuc BacLuc temporarily deployed to feature-branch October 23, 2023 12:48 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@BacLuc BacLuc removed the deploy! Creates a feature branch deployment for this PR label Oct 23, 2023
@carlobeltrame carlobeltrame added this pull request to the merge queue Oct 27, 2023
Merged via the queue into devel with commit c7d41dd Oct 27, 2023
47 checks passed
@BacLuc BacLuc deleted the login-text-key-on-dev branch October 28, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants