Copy & paste activity #3993

pmattmann · 2023-10-21T13:08:43Z

Copy and Paste Activities

draft styling + fix Clipboard info dialog feature-complete cs-fix fix tests psalm UnitTests cs-fix translation translation & cleanup

BacLuc · 2023-10-21T16:45:38Z

Es scheint als wäre der clipboard zugriff auf firefox bisschen kompliziert:

TypeError: 'clipboard-read' (value of 'name' member of PermissionDescriptor) is not a valid value for enumeration PermissionName.
    mounted CopyActivityInfoDialog.vue:49
    VueJS 19
    click CampProgram.vue:81
    VueJS 4
    onClick LockButton.vue:60
    VueJS 33

Das passiert nur schon, wenn man den edit mode im picasso aktiviert.
Wenn man dann das Kopier symbol klickt, dann gibt es kein Feedback.

Beim erstellen einer neuen Aktivität wird die console dann auch rot.

Sobald man in der aktivitäts ansicht das three dot menu aufmacht, wird die konsole auch rot.

BacLuc · 2023-10-21T16:52:47Z

In Safari hat das navigator.permissions objekt gar keine properties (oder ist wahrscheinlich null).
Es gibt einen type error

github-actions · 2023-10-21T16:57:57Z

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

api/src/Entity/Activity.php

api/src/State/ActivityCreateProcessor.php

api/tests/Api/Activities/CreateActivityTest.php

BacLuc · 2023-10-21T17:03:24Z

api/src/Entity/Activity.php

@@ -120,6 +120,13 @@ class Activity extends BaseEntity implements BelongsToCampInterface {
    #[ORM\JoinColumn(nullable: false)]
    public ?Category $category = null;

+    /**
+     * Copy Contents from this Source-Activity.


Does the source start with a capital letter

frontend/src/components/activity/ScheduleEntry.vue

frontend/src/components/program/DialogActivityCreate.vue

api/tests/Api/Activities/CreateActivityTest.php

DeNic0la · 2023-10-22T10:51:08Z

Hey, I played around a bit and noticed some things.

Copying a block has a delay or does sometimes not work.

Ecamp_3993_case_01.mp4

The URL was copied to my clipboard (I pasted it into a new tab and it worked) but was not recognized by ecamp at first.

When deleting a block while in the copy process, there is no error message. (or it didn't load on my Browser)

Ecamp_3993_case_02.mp4

Doing this is basically asking for trouble but the same thing happens when the internet connection is lost:

frontend/src/components/activity/ScheduleEntry.vue

frontend/src/components/program/DialogActivityCreate.vue

frontend/src/components/program/picasso/PicassoEntry.vue

manuelmeister

Cool

BacLuc · 2023-11-14T17:22:15Z

frontend/src/components/activity/CopyActivityInfoDialog.vue

+    <p v-if="clipboardReadState === 'granted'">
+      {{ $tc('components.activity.copyActivityInfoDialog.granted') }}
+    </p>
+    <p v-if="clipboardReadState === 'denied'">


minor:
Could we keep the button to request access also in the denied case?
On some browsers (e.g. mobile) the button to grant the permission is not that easy to find.

BacLuc · 2023-11-14T17:25:14Z

frontend/src/components/program/DialogActivityCreate.vue

+          <v-list-item-action>
+            <e-checkbox
+              v-model="copyContent"
+              :label="$tc('components.program.dialogActivityCreate.copyActivityContent')"


minor:
The label text content is a little long on mobile and hides the activity title.
But you see it in the title field and in the category field

frontend/src/components/program/DialogActivityCreate.vue

frontend/src/components/activity/ScheduleEntry.vue

frontend/src/components/program/DialogActivityCreate.vue

# Conflicts: # frontend/src/locales/de.json # frontend/src/locales/en.json

manuelmeister · 2023-12-15T17:19:43Z

I created a PR to resolve the leftover issues: pmattmann#7

Feature/copy activity

eslint

BacLuc · 2023-12-17T16:27:05Z

You need to merge devel again after #4136

Add 'Copy Activity'-Function to Copy ScheduleEntry-Url

264ee4b

draft styling + fix Clipboard info dialog feature-complete cs-fix fix tests psalm UnitTests cs-fix translation translation & cleanup

pmattmann force-pushed the feature/copy-activity branch from f5fccff to 264ee4b Compare October 21, 2023 15:53

pmattmann marked this pull request as ready for review October 21, 2023 15:54

pmattmann added the deploy! Creates a feature branch deployment for this PR label Oct 21, 2023

pmattmann temporarily deployed to feature-branch October 21, 2023 16:25 — with GitHub Actions Inactive

pmattmann changed the title ~~Feature/copy activity~~ Copy & paste activity Oct 21, 2023

update snapshot

04d854b

pmattmann temporarily deployed to feature-branch October 21, 2023 17:10 — with GitHub Actions Inactive

BacLuc reviewed Oct 21, 2023

View reviewed changes

code-review

84bef9a

BacLuc reviewed Oct 21, 2023

View reviewed changes

api/tests/Api/Activities/CreateActivityTest.php Show resolved Hide resolved

fix comment

618b40e

pmattmann temporarily deployed to feature-branch October 21, 2023 20:15 — with GitHub Actions Inactive

firefox-compatible

da3fd09

pmattmann temporarily deployed to feature-branch October 21, 2023 21:49 — with GitHub Actions Inactive

firefox and safari compatible

7ac7fc5

pmattmann temporarily deployed to feature-branch October 21, 2023 23:57 — with GitHub Actions Inactive

visual improvments; copy location & category

0e02f56

pmattmann temporarily deployed to feature-branch October 22, 2023 10:15 — with GitHub Actions Inactive

fix async loading

bbcbde6

DeNic0la reviewed Oct 22, 2023

View reviewed changes

frontend/src/components/activity/ScheduleEntry.vue Outdated Show resolved Hide resolved

await writeText()

b330ff5

pmattmann temporarily deployed to feature-branch October 22, 2023 11:48 — with GitHub Actions Inactive

loading-spinner

0cfd3b2

pmattmann temporarily deployed to feature-branch October 22, 2023 12:02 — with GitHub Actions Inactive

BacLuc reviewed Oct 22, 2023

View reviewed changes

add translations

3e9ef0a

pmattmann temporarily deployed to feature-branch November 10, 2023 20:45 — with GitHub Actions Inactive

fix button-text

fd46abe

pmattmann temporarily deployed to feature-branch November 10, 2023 20:54 — with GitHub Actions Inactive

pmattmann requested review from manuelmeister and BacLuc November 10, 2023 21:12

manuelmeister approved these changes Nov 10, 2023

View reviewed changes

BacLuc approved these changes Nov 14, 2023

View reviewed changes

manuelmeister reviewed Nov 18, 2023

View reviewed changes

frontend/src/components/activity/ScheduleEntry.vue Outdated Show resolved Hide resolved

manuelmeister requested changes Nov 18, 2023

View reviewed changes

frontend/src/components/program/DialogActivityCreate.vue Show resolved Hide resolved

manuelmeister added 2 commits December 11, 2023 18:05

Merge remote-tracking branch 'upstream/devel' into feature/copy-activity

ee5bd25

# Conflicts: # frontend/src/locales/de.json # frontend/src/locales/en.json

Implement review feedback

4ea6fd0

Merge pull request #7 from manuelmeister/feature/copy-activity

fccf59d

Feature/copy activity

pmattmann temporarily deployed to feature-branch December 17, 2023 13:24 — with GitHub Actions Inactive

Update ScheduleEntry.vue

9d46cfc

eslint

pmattmann temporarily deployed to feature-branch December 17, 2023 13:29 — with GitHub Actions Inactive

update snapshot

de53d84

pmattmann temporarily deployed to feature-branch December 17, 2023 14:21 — with GitHub Actions Inactive

pmattmann requested a review from manuelmeister December 17, 2023 14:26

Merge remote-tracking branch 'upstream/devel' into feature/copy-activity

c8b15ec

manuelmeister approved these changes Dec 17, 2023

View reviewed changes

manuelmeister enabled auto-merge December 17, 2023 20:42

manuelmeister temporarily deployed to feature-branch December 17, 2023 20:44 — with GitHub Actions Inactive

manuelmeister added this pull request to the merge queue Dec 17, 2023

Merged via the queue into ecamp:devel with commit 45d4e38 Dec 17, 2023
31 checks passed

carlobeltrame mentioned this pull request Jan 27, 2024

Copy Block Feature #3376

Closed

carlobeltrame mentioned this pull request Mar 26, 2024

Copy category from other category or from activity #4823

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy & paste activity #3993

Copy & paste activity #3993

pmattmann commented Oct 21, 2023

BacLuc commented Oct 21, 2023

BacLuc commented Oct 21, 2023

github-actions bot commented Oct 21, 2023 •

edited

Loading

BacLuc Oct 21, 2023

DeNic0la commented Oct 22, 2023

manuelmeister left a comment

BacLuc Nov 14, 2023

BacLuc Nov 14, 2023

manuelmeister commented Dec 15, 2023

BacLuc commented Dec 17, 2023

Copy & paste activity #3993

Copy & paste activity #3993

Conversation

pmattmann commented Oct 21, 2023

BacLuc commented Oct 21, 2023

BacLuc commented Oct 21, 2023

github-actions bot commented Oct 21, 2023 • edited Loading

⛔ Feature branch deployment currently inactive.

BacLuc Oct 21, 2023

Choose a reason for hiding this comment

DeNic0la commented Oct 22, 2023

manuelmeister left a comment

Choose a reason for hiding this comment

BacLuc Nov 14, 2023

Choose a reason for hiding this comment

BacLuc Nov 14, 2023

Choose a reason for hiding this comment

manuelmeister commented Dec 15, 2023

BacLuc commented Dec 17, 2023

github-actions bot commented Oct 21, 2023 •

edited

Loading