Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Category color allows empty strings #3871

Closed
usu opened this issue Sep 30, 2023 · 0 comments · Fixed by #4033
Closed

Category color allows empty strings #3871

usu opened this issue Sep 30, 2023 · 0 comments · Fixed by #4033
Labels
Bug Good first issue

Comments

@usu
Copy link
Member

usu commented Sep 30, 2023

Our API allows a patch on category with color:""

This breaks the frontend (CategoryChip: "TypeError: Empty color reference").

Reason is that Symfony regex constraint accepts null & empty values as valid:
https://symfony.com/doc/current/reference/constraints/Regex.html

Should be combined with a NotBlank constraint, or frontend need to be able to handle null values or empty values.
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Oct 31, 2023
@BacLuc
api: assert that color is not blank in Category
5e34119 
And trim the color for manual inputs.
closes ecamp#3871
@BacLuc BacLuc mentioned this issue Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: assert that color is not blank in Category BacLuc/ecamp3
1 participant
@usu