Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated fromMnemonic integration test and file name #2745

Merged
merged 16 commits into from
Dec 5, 2023
Merged

updated fromMnemonic integration test and file name #2745

merged 16 commits into from
Dec 5, 2023

Conversation

dsawali
Copy link
Contributor

@dsawali dsawali commented Nov 29, 2023 •
edited
Loading

closes #2741

P.S. Updated a few other tests that were persistently failing on Flextesa. There are some flakiness with existing tests that has an origination operation in Flextesa, will investigate further in a separate ticket.

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 1abdc03
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/656e58c880f29c000840b21f
😎 Deploy Preview https://deploy-preview-2745--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dsawali dsawali changed the title updated integration test and file name updated fromMnemonic integration test and file name Nov 29, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

A new deploy preview is available on Netlify at https://25de25f--tezostaquito.netlify.app

@dsawali dsawali requested review from hui-an-yang and ac10n November 30, 2023 19:46
@dsawali dsawali marked this pull request as ready for review November 30, 2023 19:46
hui-an-yang
hui-an-yang approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@hui-an-yang hui-an-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, looks good overall

@dsawali dsawali merged commit e161bc7 into master Dec 5, 2023
@dsawali dsawali deleted the 2741-fix-mnemonic branch December 5, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hui-an-yang hui-an-yang hui-an-yang approved these changes

@ac10n ac10n Awaiting requested review from ac10n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix fromMnemonic tests
2 participants
@dsawali @hui-an-yang