Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle taquito beacon wallet #2744

Merged
merged 11 commits into from
Mar 5, 2024
Merged

Conversation

hui-an-yang
Copy link
Collaborator

@hui-an-yang hui-an-yang commented Nov 29, 2023

Adding taquito-beacon-wallet bundling to ci

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit a9a3cbb
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/65e611488966e80008143e13
😎 Deploy Preview https://deploy-preview-2744--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hui-an-yang hui-an-yang added this to the v17.5 milestone Nov 29, 2023
Copy link

github-actions bot commented Nov 29, 2023

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

Copy link

github-actions bot commented Nov 29, 2023

A new deploy preview is available on Netlify at https://f41231d--tezostaquito.netlify.app

@hui-an-yang hui-an-yang requested review from dsawali and ac10n November 29, 2023 22:33
@hui-an-yang hui-an-yang marked this pull request as ready for review November 29, 2023 23:08
@dsawali
Copy link
Contributor

dsawali commented Nov 30, 2023

@hui-an-yang have we tested whether the beacon wallet bundle is importable and usable?

@oldominion
Copy link

oldominion commented Jan 20, 2024

I've tested the bundle described here, and successfully been able to do what I need to do from a JS environment (Blazor WASM, which has only JS interop).

importing the bundles in index.html:

<script src="_content/BeaconWalletComponent/taquito.min.js"></script>
<script src="_content/BeaconWalletComponent/taquito_beacon_wallet.js"></script>

In a beaconWrapper.js file that I call via interop:

const taquitoTezos = new taquito.TezosToolkit("<RPC_URL>");
const taquitoWallet = new taquito_beacon_wallet.BeaconWallet({
            name: dAppName,
            preferredNetwork: networkType
        });
taquitoTezos.setWalletProvider(taquitoWallet);

Is there a reason this PR was closed? It would be very useful to have this in the master branch so that I can have Visual Studio build the bundles as part of my build process, rather than having to manually build and import the taquito_beacon_wallet.js file to my project.

I've also added a comment to #2694 describing what I think the problem might have been for the OP.

@dsawali
Copy link
Contributor

dsawali commented Jan 22, 2024

Hey @oldominion, it was closed back then because the bundle was tested in a browser import directly but wasn't working as intended. But I'm glad the contents of this bundle worked for your problem.

May I ask how you are building Taquito locally for your Blazor project? If this does get merged to master, we will also upload the bundle as a .zip file on a release.

@dsawali dsawali reopened this Jan 22, 2024
@oldominion
Copy link

oldominion commented Jan 23, 2024

I just built with..

cd Taquito\taquito\packages\taquito-beacon-wallet 
'npm run build-webpack' or 'npx webpack --config webpack.config.js'

..then imported the taquito_beacon_wallet.js file via <script> tag as described earlier.

@dsawali
Copy link
Contributor

dsawali commented Jan 23, 2024

@oldominion perfect, that's exactly how we'd intended this bundle to be used. We'll test it a bit more and then release it sometime soon.

When it does reach master and gets an official release, you can expect to directly be able to grab the taquito_beacon_wallet.js in a zip file included with the release.

@hui-an-yang hui-an-yang modified the milestones: v17.5, v19.1 Feb 20, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 4, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a9a3cbb
Status: ✅  Deploy successful!
Preview URL: https://8e3dfead.taquito.pages.dev
Branch Preview URL: https://bundle-taquito-beacon-wallet.taquito.pages.dev

View logs

@hui-an-yang hui-an-yang merged commit 9f1718b into master Mar 5, 2024
13 checks passed
@hui-an-yang hui-an-yang deleted the bundle-taquito-beacon-wallet branch March 5, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants