Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove archive node reference #2743

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Remove archive node reference #2743

merged 5 commits into from
Nov 29, 2023

Conversation

hui-an-yang
Copy link
Collaborator

@hui-an-yang hui-an-yang commented Nov 28, 2023 •
edited
Loading

removing archive node reference in integration-tests/rpc-get-protocol-constants.spec.ts

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023 •
edited
Loading

✅ Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 6a28865
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/65653bab21f2750008410bc1
😎 Deploy Preview https://deploy-preview-2743--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@hui-an-yang hui-an-yang requested review from ac10n and dsawali November 28, 2023 01:03
@hui-an-yang
Copy link
Collaborator Author

We pointed our protocol constants test to a rolling node https://mainnet.ecadinfra.com/, it only persists data for around 13 cycles prior with this limitation we are only able to query and constantly testing for the current protocol.

@github-actions GitHub Actions
Copy link

A new deploy preview is available on Netlify at https://1d2872c--tezostaquito.netlify.app

@hui-an-yang hui-an-yang marked this pull request as ready for review November 28, 2023 17:10
@hui-an-yang hui-an-yang self-assigned this Nov 28, 2023
@hui-an-yang hui-an-yang added this to the v17.5 milestone Nov 28, 2023
@hui-an-yang hui-an-yang merged commit b84d11d into master Nov 29, 2023
11 of 12 checks passed
@hui-an-yang hui-an-yang deleted the remove-archive-node-reference branch November 29, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsawali dsawali dsawali approved these changes

@ac10n ac10n Awaiting requested review from ac10n

Assignees

@hui-an-yang hui-an-yang

Labels
None yet
Projects
Taquito Dev
Status: Done
Milestone
v17.5
Development

Successfully merging this pull request may close these issues.
2 participants
@hui-an-yang @dsawali