added detectOpenHandles #2721
Merged
added detectOpenHandles #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taquito-test-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages: |
|
A new deploy preview is available on Netlify at https://1439fb1--tezostaquito.netlify.app |
ac10n
reviewed
Nov 9, 2023
| @@ -112,7 +112,7 @@ jobs: | |||
| --protocol-kind ${{ matrix.protocol }} | |||
| - run: npm ci | |||
| - run: npm run build | |||
| - run: npm -w integration-tests run test:originate-known-contracts && npm -w integration-tests run test:${{ matrix.testnet }}-secret-key -- --testPathIgnorePatterns ledger-signer-failing-tests.spec.ts ledger-signer.spec.ts contract-estimation-tests.spec.ts rpc-get-protocol-constants.spec.ts sandbox-ballot-operation.spec.ts | |||
| - run: npm -w integration-tests run test:originate-known-contracts && npm -w integration-tests run test:${{ matrix.testnet }}-secret-key -- --testPathIgnorePatterns ledger-signer-failing-tests.spec.ts ledger-signer.spec.ts contract-estimation-tests.spec.ts rpc-get-protocol-constants.spec.ts sandbox-ballot-operation.spec.ts contract-batch-high-number-of-operations.spec.ts --detectOpenHandles --runInBand | |||
There was a problem hiding this comment.
Just a suggestion for future: we can have a helper function isSandbox and skip tests in the spec.ts files. This will make it explicit that the test is skipped in sandbox, in the test file. Also, currently different tests will be run if we run tests according to the README file, vs what happens in the CI.
ac10n
reviewed
Nov 9, 2023
|
|
||
| CONFIGS().forEach(({ lib, rpc, setup }) => { | ||
| const Tezos = lib; | ||
|
|
||
| describe(`Test contract origination of a contract that calls 2nd contract that FAILs through contract api: ${rpc}`, () => { | ||
| let contract: DefaultContractType; |
There was a problem hiding this comment.
Also for future, when some data is needed in a test, we can create a function that's called in the it and returns the needed data. It's functionally not important, as tests inside one file are run in series and not in parallel,
ac10n
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.S. the errors sometimes does still happen when blobs of JSON are outputted to the console when throwing errors, but much less so compared to before. This will hopefully be fixed in future Jest versions
Slack thread for context: https://ecadlabs.slack.com/archives/C03M4EFE9RP/p1699394835679869
Related Jest issue: jestjs/jest#10577
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBERin the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.