Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update lerna and dependencies #2687

Closed
wants to merge 1 commit into from
Closed

chore: update lerna and dependencies #2687

wants to merge 1 commit into from

Conversation

ac10n
Copy link
Contributor

@ac10n ac10n commented Oct 4, 2023

Update Lerna and related dependencies to latest version
closes #2612

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

@netlify
Copy link

netlify bot commented Oct 4, 2023 •
edited
Loading

✅ Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit c5596d7
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/651da84548e46d00071e5bb3
😎 Deploy Preview https://deploy-preview-2687--taquito-test-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ac10n ac10n requested a review from dsawali October 4, 2023 18:00
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

A new deploy preview is available on Netlify at https://9550124--tezostaquito.netlify.app

@ac10n ac10n requested a review from hui-an-yang October 4, 2023 18:32
hui-an-yang
hui-an-yang reviewed Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@hui-an-yang hui-an-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have we tried all pacakge.json commands related to lerna and release process commands to know that it works as before?

@ac10n
Copy link
Contributor Author

ac10n commented Oct 4, 2023

have we tried all pacakge.json commands related to lerna and release process commands to know that it works as before?

I have tried everything short of actually releasing. We can test that when trying to do the next release

@hui-an-yang
Copy link
Collaborator

Just hope it's not too late to found incompatibility when releasing

@ac10n
Copy link
Contributor Author

ac10n commented Oct 5, 2023

Just hope it's not too late to found incompatibility when releasing

Do you have any suggestion?

@dsawali
Copy link
Contributor

dsawali commented Oct 6, 2023

@AlirezaHaghshenas @hui-an-yang the upgrade seems to be fine judging from this build https://github.com/ecadlabs/taquito/actions/runs/6409735868/job/17401558342?pr=2687

although I am still a bit hesitant on merging this right now.

@ac10n
Copy link
Contributor Author

ac10n commented Oct 6, 2023

@AlirezaHaghshenas @hui-an-yang the upgrade seems to be fine judging from this build https://github.com/ecadlabs/taquito/actions/runs/6409735868/job/17401558342?pr=2687

although I am still a bit hesitant on merging this right now.

What do we need to get more confidence?

@ac10n
Copy link
Contributor Author

ac10n commented Oct 17, 2023

This can be closed in favor of #2693

@ac10n ac10n closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hui-an-yang hui-an-yang hui-an-yang left review comments

@dsawali dsawali Awaiting requested review from dsawali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Taquito dependencies except axios
3 participants
@ac10n @hui-an-yang @dsawali