Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed remaining tx_rollup references #2675

Merged
merged 5 commits into from
Sep 29, 2023
Merged

removed remaining tx_rollup references #2675

merged 5 commits into from
Sep 29, 2023

Conversation

dsawali
Copy link
Contributor

@dsawali dsawali commented Sep 27, 2023 •
edited
Loading

closes #2650
Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@dsawali dsawali marked this pull request as ready for review September 28, 2023 19:29
@dsawali dsawali linked an issue Sep 28, 2023 that may be closed by this pull request
removed all tx rollup ref #2650
Closed
hui-an-yang
hui-an-yang reviewed Sep 29, 2023
View reviewed changes
packages/taquito-rpc/src/types.ts
@@ -1960,7 +1560,7 @@ export interface OperationMetadataBalanceUpdates {
change: string;
origin: MetadataBalanceUpdatesOriginEnum;
category?: MetadataBalanceUpdatesCategoryEnum;
staker?: { contract?: string, delegate: string };
staker?: { contract?: string; delegate: string };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you!

hui-an-yang
hui-an-yang approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@hui-an-yang hui-an-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to also clean up txr1, otherwise lgtm

@dsawali dsawali merged commit a0f22c3 into oxford Sep 29, 2023
@dsawali dsawali deleted the 2650-remove-toru branch September 29, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hui-an-yang hui-an-yang hui-an-yang approved these changes

@ac10n ac10n Awaiting requested review from ac10n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

removed all tx rollup ref
2 participants
@dsawali @hui-an-yang