Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @taquito/core as explicit dependency #2673

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Add @taquito/core as explicit dependency #2673

merged 8 commits into from
Sep 28, 2023

Conversation

hui-an-yang
Copy link
Collaborator

@hui-an-yang hui-an-yang commented Sep 27, 2023 •
edited
Loading

make @taquito/core as explicit dependency in each packages

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@netlify
Copy link

netlify bot commented Sep 27, 2023 •
edited
Loading

✅ Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 4699a0a
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/65158f13f4736d0008af3fae
😎 Deploy Preview https://deploy-preview-2673--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

A new deploy preview is available on Netlify at https://6e6aaf6--tezostaquito.netlify.app

@hui-an-yang hui-an-yang marked this pull request as ready for review September 27, 2023 19:52
dsawali
dsawali suggested changes Sep 28, 2023
View reviewed changes
website/package.json Outdated
@@ -28,6 +28,7 @@
"@ledgerhq/hw-transport-webhid": "^6.27.19",
"@mdx-js/react": "^1.6.22",
"@svgr/webpack": "^8.1.0",
"@taquito/core": "file:../packages/taquito-rpc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it should be taquito/core?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch will update, thank you!!

@hui-an-yang hui-an-yang requested a review from dsawali September 28, 2023 21:27
@hui-an-yang hui-an-yang merged commit 7211847 into master Sep 28, 2023
9 of 11 checks passed
@hui-an-yang hui-an-yang deleted the add-@taquito/core-as-explicit-dependency branch September 28, 2023 22:28
@Innkst Innkst added this to the v17.3.2 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsawali dsawali dsawali approved these changes

@ac10n ac10n Awaiting requested review from ac10n

Assignees
No one assigned
Labels
None yet
Projects
Taquito Dev
Status: Done
Milestone
v17.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@hui-an-yang @dsawali @Innkst