-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2596 oxfrod rpc returned type update #2652
Conversation
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
…-rpc-returned-type-update
*/ | ||
async getBlock({ block }: RPCOptions = defaultRPCOptions): Promise<BlockResponse> { | ||
async getBlock({ block, version }: RPCOptions = defaultRPCOptions): Promise<BlockResponse> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There can be a design decision here: If we go with the current design, the calls to getBlock
will need to have a version included forever. Another design might be to have an RPC_VERSION
setting somewhere that affects this. Then the dapp can set that in one place and forget about it.
getTxRollupState
&getTxRollupInbox
getBlock
,getBlockMetadata
,preapplyOperations
,runOperation
,simulateOperation
with RPCOptions version . Default{ version: '0' }
will show kindendorsement
;{ version: '1' }
will show kindattestation
.getPendingOperation
with RPCOptions version. Default{ version: '1' }
will show{ applied: { kind: 'endorsement' } }
;{ version: '2 }
will show{ validated: { kind: 'attestation' } }
closes #2596
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.