Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: convert Ligo examples to a more modern style #2638

Closed
wants to merge 2 commits into from

Conversation

aguillon
Copy link

@aguillon aguillon commented Sep 6, 2023

I saw a Ligo example with an outdated style in https://tezostaquito.io/docs/smartcontracts/. Ligo should reach v1 in the coming weeks, and main functions will most likely become deprecated. Also this example is easier to read now.

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 4c95e0a
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/64f7e530f689c10008aaebaf
😎 Deploy Preview https://deploy-preview-2638--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hui-an-yang hui-an-yang requested a review from ac10n September 8, 2023 18:14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution. Sorry for late reply, looks like ligo have updated their syntax. I hope you don't mind update the counter contract to the latest?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @aguillon, we really appreciate your suggestion and contribution to update the contract. Unfortunately, I have no luck of compiling this contract for now. Am wondering if you'll mind updating it with the latest syntax and let us know if you compile it with success?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hui-an-yang As you have noticed, I was a bit too early with those changes, and Ligo seems to have changed again since. I'll wait a few days before making sure they compile with the current v1.

@hui-an-yang
Copy link
Collaborator

Hello @aguillon,
I have created pr#2750 with the new jsligo v1.1.0 semantic, hoping to fix this issue

@hui-an-yang hui-an-yang mentioned this pull request Dec 6, 2023
9 tasks
@hui-an-yang
Copy link
Collaborator

closing since pr2750 has been merged into main branch

@hui-an-yang hui-an-yang closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants