-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: convert Ligo examples to a more modern style #2638
Conversation
✅ Deploy Preview for taquito-test-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution. Sorry for late reply, looks like ligo have updated their syntax. I hope you don't mind update the counter contract to the latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @aguillon, we really appreciate your suggestion and contribution to update the contract. Unfortunately, I have no luck of compiling this contract for now. Am wondering if you'll mind updating it with the latest syntax and let us know if you compile it with success?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hui-an-yang As you have noticed, I was a bit too early with those changes, and Ligo seems to have changed again since. I'll wait a few days before making sure they compile with the current v1.
closing since pr2750 has been merged into main branch |
I saw a Ligo example with an outdated style in https://tezostaquito.io/docs/smartcontracts/. Ligo should reach v1 in the coming weeks, and
main
functions will most likely become deprecated. Also this example is easier to read now.