2065 local forging support new operations for lima #2106

hui-an-yang · 2022-11-07T17:49:19Z

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

Your code builds cleanly without any errors or warnings
You have added unit tests
You have added integration tests (if relevant/appropriate)
All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
You have added or updated corresponding documentation
If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

…inDelegate in Lima re #2066

re #2066

re #2065

…-provider re #2065

…CEstimateProvider re #2065

github-actions · 2022-11-08T00:33:11Z

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

re #2065

codecov-commenter · 2022-11-08T01:12:14Z

Codecov Report

❗ No coverage uploaded for pull request base (lima@ecade81). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             lima    #2106   +/-   ##
=======================================
  Coverage        ?   81.34%           
=======================================
  Files           ?      222           
  Lines           ?    12412           
  Branches        ?     2781           
=======================================
  Hits            ?    10097           
  Misses          ?     2293           
  Partials        ?       22

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…rging-support-new-operations-for-lima

…new-encoding-for-ticket-in-lima

…h tests re #2072

…new-encoding-for-ticket-in-lima

* Fix taquito-test-dapp build when using local packages * Add build script for test-dapp to root package.json * Commit apps/taquito-test-dapp/package-lock.json * Exclude @taquito/website and taquito-test-dapp-vite from nx build command * Fix deploy_website pipeline * Re-link local dependencies when deploying on Netlify * Only run Taquito packages unit tests * Remove empty NPM test script from pack-test-tool * Rebuild dependencies when on Netlify * Use workspaces * Remove prebuild-test-dapp script * Fix taquito-test-dapp build * Install lerna in apps/taquito-test-dapp * Trigger Netlify cache deploy * Remove typeRoots propriety from every tsconfig.json * Fix dependencies for website * Delete unused package-lock.json * Correctly link local dependencies * Fix taquito-http-utils * Replace docusaurus2-dotenv with docusaurus-plugin-dotenv * Use NPM workspaces to run commands * Fix Jest testResultsProcessor path * Revert webpack upgrade in @taquito/taquito * Update package-lock.json * Update package-lock.json * Upgrade @taquito/taquito to webpack5 * Update codecov Github Action * Trigger build * Remove deprecated Jakartanet testnet from Taquito Test Dapp * Update root Readme.md file with the latest changes for building Taquito Co-authored-by: roxaneletourneau <[email protected]>

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.1...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

… lima re #2072

…rging-support-new-operations-for-lima

re #2072

….com:ecadlabs/taquito into 2065-local-forging-support-new-operations-for-lima

re #2065

roxaneletourneau

Good work, some minor comments about the tests.

Can you open an issue to remind us to delete "taquito-local-forging/src/proto14-kathmandu/" when we will be working on M protocol?

roxaneletourneau · 2022-11-18T23:42:35Z

integration-tests/contract-edo-deploy-having-ticket.spec.ts


  describe(`Test origination of a token contract using: ${rpc}`, () => {

    beforeEach(async (done) => {
      await setup();
      done()
    })
-    test('Originates a contract having ticket with init and the wallet api', async (done) => {
+    kathmandunet('Originates a contract having ticket with init and the wallet api', async (done) => {


I think this specific test is duplicated from "integration-tests/wallet-edo-deploy-having-ticket.spec.ts". Can it be removed?

roxaneletourneau · 2022-11-18T23:43:07Z

integration-tests/contract-edo-deploy-having-ticket.spec.ts

+      await setup();
+      done()
+    })
+    limanetAndAlpha('Originates a contract having ticket with init and the wallet api', async (done) => {


Same for this one that seems to be duplicated in integration-tests/wallet-edo-deploy-having-ticket.spec.ts

roxaneletourneau · 2022-11-19T00:05:08Z

integration-tests/data/allTestsCases.ts

+
+export const limaCases: TestCase[] = [
+  // In `opMapping` from the file `constants.ts`, the operations and types starting at `ticket` were added in the lima protocol
+  ...extractOp(154, 154, opMapping).map((op): TestCase => {


Can we test from 152 to 154 to include lambda_rec as well?

roxaneletourneau · 2022-11-19T00:07:34Z

integration-tests/data/allTestsCases.ts

@@ -1345,7 +1347,7 @@ export const commonCases: TestCase[] = [
 ];

 export const kathmanduCases: TestCase[] = [
-  ...extractOp(150, 151, opMapping).map((op): TestCase => {
+  ...extractOp(150, 151, opMappingProto14).map((op): TestCase => {


Can we move the following tests:

Origination of a contract that contains the instructions EMIT

Increase Paid Storage operation
into commonCases ? Those operation/instruction are now supported on every protocol we are testing against (Kathmandu, Lima, alpha and upcoming)

…ommoncases re #2065

…-utils-1.4.2 build(deps): bump loader-utils from 1.4.1 to 1.4.2

dsawali · 2022-11-21T21:38:31Z

.github/workflows/deploy_website.yml

@@ -17,7 +17,7 @@ jobs:
    - uses: actions/checkout@v3
    - uses: actions/setup-node@v3
      with:
-        node-version: 16.13.1
+        node-version: 16


what's the reasoning behind this change?

is this perhaps from master?

dsawali · 2022-11-21T21:40:34Z

Does this branch have changes from the recent master?

hui-an-yang added 16 commits August 8, 2022 11:02

Merge branch 'master' of github.com:ecadlabs/taquito

47cf160

Merge branch 'master' of github.com:ecadlabs/taquito

53bf5c5

Merge branch 'master' of github.com:ecadlabs/taquito

eddeb1d

Merge branch 'master' of github.com:ecadlabs/taquito

ac9bd70

Merge branch 'master' of github.com:ecadlabs/taquito

ca9577d

Merge branch 'master' of github.com:ecadlabs/taquito

8c1643d

Merge branch 'master' of github.com:ecadlabs/taquito

d34128b

Merge branch 'master' of github.com:ecadlabs/taquito

ad53532

Merge branch 'master' of github.com:ecadlabs/taquito

1d175f5

Merge branch 'master' of github.com:ecadlabs/taquito

b1414ef

feat: support new types for new operations UpdateConsensusKey and Dra…

c029847

…inDelegate in Lima re #2066

test: update_consensus_key unit test added for limanet

33489db

re #2066

feat: support new operation UpdateConsensusKey for Lima

029efa1

re #2065

feat: support new operation updateConsensusKey in local-forger for Lima

2992fcf

re #2065

revert: removed unnecesorry change of updateConsensusKey in rpc-batch…

edd3f63

…-provider re #2065

revert: changes of update_consensus_key in RpcContractProvider and RP…

e0126e5

…CEstimateProvider re #2065

feat: support new operation drainDelegate for Lima

984e3a5

re #2065

hui-an-yang and others added 11 commits November 8, 2022 11:03

Merge branch 'lima' of github.com:ecadlabs/taquito into 2065-local-fo…

1c0a203

…rging-support-new-operations-for-lima

Merge branch 'lima' of github.com:ecadlabs/taquito into 2072-support-…

db4db3d

…new-encoding-for-ticket-in-lima

feat: support new encoding for ticket & ticket depreacted in lima wit…

b2f4a98

…h tests re #2072

Merge branch 'lima' of github.com:ecadlabs/taquito into 2072-support-…

3f0723c

…new-encoding-for-ticket-in-lima

fix: added ASSERT_SOME in ticketCode and fixed 2 integration tests in…

4070a28

… lima re #2072

Merge branch 'lima' of github.com:ecadlabs/taquito into 2065-local-fo…

d978b87

…rging-support-new-operations-for-lima

fixs merge conflicts

64903a8

fix: fixs merge conflicts

6628b93

fix: replaced ASSERT_SOME with its expansion in ticketCode

5b73497

re #2072

hui-an-yang added 3 commits November 18, 2022 13:21

fix: resolving merge conflicts with lima

dbc38dc

Merge branch '2072-support-new-encoding-for-ticket-in-lima' of github…

9c71ca0

….com:ecadlabs/taquito into 2065-local-forging-support-new-operations-for-lima

test: added local-forgin integration tests for new operations

f3761d5

re #2065

hui-an-yang marked this pull request as ready for review November 18, 2022 21:48

hui-an-yang linked an issue Nov 18, 2022 that may be closed by this pull request

Local-forging: Support the new operations for Lima #2065

Closed

hui-an-yang requested review from roxaneletourneau and dsawali November 18, 2022 22:21

roxaneletourneau reviewed Nov 19, 2022

View reviewed changes

hui-an-yang and others added 4 commits November 18, 2022 18:29

fix: address comments removed duplicate tests and move kathcases to c…

db7ece5

…ommoncases re #2065

Merge pull request #2129 from ecadlabs/dependabot/npm_and_yarn/loader…

7965eb0

…-utils-1.4.2 build(deps): bump loader-utils from 1.4.1 to 1.4.2

fix: resolved merge conflicts from master

cc7dc6d

fix: resolved merge conflicts from master 2

431c646

dsawali reviewed Nov 21, 2022

View reviewed changes

fix: fixs pr run

82143fd

hui-an-yang linked an issue Nov 22, 2022 that may be closed by this pull request

Local-forging: Support new encoding for TICKET for Lima #2072

Closed

hui-an-yang closed this Nov 22, 2022

hui-an-yang removed a link to an issue Nov 23, 2022

Local-forging: Support the new operations for Lima #2065

Closed

hui-an-yang deleted the 2065-local-forging-support-new-operations-for-lima branch November 23, 2022 21:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2065 local forging support new operations for lima #2106

2065 local forging support new operations for lima #2106

hui-an-yang commented Nov 7, 2022

github-actions bot commented Nov 8, 2022 •

edited

Loading

codecov-commenter commented Nov 8, 2022 •

edited

Loading

roxaneletourneau left a comment

roxaneletourneau Nov 18, 2022 •

edited

Loading

roxaneletourneau Nov 18, 2022

roxaneletourneau Nov 19, 2022

roxaneletourneau Nov 19, 2022

dsawali Nov 21, 2022

dsawali Nov 21, 2022

dsawali commented Nov 21, 2022

2065 local forging support new operations for lima #2106

2065 local forging support new operations for lima #2106

Conversation

hui-an-yang commented Nov 7, 2022

Release Note Draft Snippet

github-actions bot commented Nov 8, 2022 • edited Loading

Published packages:

codecov-commenter commented Nov 8, 2022 • edited Loading

Codecov Report

roxaneletourneau left a comment

Choose a reason for hiding this comment

roxaneletourneau Nov 18, 2022 • edited Loading

Choose a reason for hiding this comment

roxaneletourneau Nov 18, 2022

Choose a reason for hiding this comment

roxaneletourneau Nov 19, 2022

Choose a reason for hiding this comment

roxaneletourneau Nov 19, 2022

Choose a reason for hiding this comment

dsawali Nov 21, 2022

Choose a reason for hiding this comment

dsawali Nov 21, 2022

Choose a reason for hiding this comment

dsawali commented Nov 21, 2022

github-actions bot commented Nov 8, 2022 •

edited

Loading

codecov-commenter commented Nov 8, 2022 •

edited

Loading

roxaneletourneau Nov 18, 2022 •

edited

Loading